Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix storages replication (a query was using wrong ConsolidationMode) #644

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

JEnoch
Copy link
Member

@JEnoch JEnoch commented Jan 11, 2024

Fixes #643.

A query from the Aligner was using Auto as ConsolidationMode, while the Align Queryable has to send several replies with the same key. The None ConsolidationMode shall be used in such case.

Not sure why this used to work at some point. Possible the regression come from some change in the Auto ConsolidationMode, that used resolved to None in this use case, but now resolves to Latest.
Anyway, for this alignment use case, the ConsolidationMode shall definitely be None

@JEnoch JEnoch requested a review from p-avital January 11, 2024 10:38
@JEnoch JEnoch merged commit 2ad877c into master Jan 11, 2024
15 checks passed
jerry73204 pushed a commit to NEWSLabNTU/zenoh that referenced this pull request Jan 12, 2024
@Mallets Mallets deleted the fix_643 branch January 23, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Storages startup replication doesn't work
2 participants