Able to unwrap while using reply with attachment.

[evshary]

While we add with_attachment after the reply, it returns Result and it's intuitive for users to use unwrap()
https://github.com/eclipse-zenoh/zenoh/blob/main/zenoh/src/queryable.rs#L166
However, ReplyBuilder doesn't implement Debug, so we can't use unwrap()

let replybuilder = query
            .reply(reply)
            .with_attachment(attachment.build())
            .unwrap();  //<----- Error here

Although there are other ways to handle the error (like map_err), I'm just wondering whether it's possible to support Debug for ReplyBuilder.

[Mallets]

To me looks ok to add Debug to the ReplyBuilder. Do other builders derive Debug as well? If not I believe any builder should derive Debug. Chiming in @p-avital .

[evshary]

OK, let me list the builder:

• PutBuilder: https://github.com/eclipse-zenoh/zenoh/blob/main/zenoh/src/publication.rs#L79
• PublishBuilder: https://github.com/eclipse-zenoh/zenoh/blob/main/zenoh/src/publication.rs#L683
• MatchingListenerBuilder: https://github.com/eclipse-zenoh/zenoh/blob/main/zenoh/src/publication.rs#L987
• ZidBuilder: https://github.com/eclipse-zenoh/zenoh/blob/main/zenoh/src/info.rs#L35
• RoutersZidBuilder: https://github.com/eclipse-zenoh/zenoh/blob/main/zenoh/src/info.rs#L72C12-L72C29
• PeersZidBuilder: https://github.com/eclipse-zenoh/zenoh/blob/main/zenoh/src/info.rs#L118
• LivelinessTokenBuilder: https://github.com/eclipse-zenoh/zenoh/blob/main/zenoh/src/liveliness.rs#L220C12-L220C34
• LivelinessSubscriberBuilder: https://github.com/eclipse-zenoh/zenoh/blob/main/zenoh/src/liveliness.rs#L411C12-L411C39
• LivelinessGetBuilder: https://github.com/eclipse-zenoh/zenoh/blob/main/zenoh/src/liveliness.rs#L605C12-L605C32
• GetBuilder: https://github.com/eclipse-zenoh/zenoh/blob/main/zenoh/src/query.rs#L121
• ReplyBuilder: https://github.com/eclipse-zenoh/zenoh/blob/main/zenoh/src/queryable.rs#L158
• QueryableBuilder: https://github.com/eclipse-zenoh/zenoh/blob/main/zenoh/src/queryable.rs#L413
• ScoutBuilder: https://github.com/eclipse-zenoh/zenoh/blob/main/zenoh/src/scouting.rs#L49
• SubscriberBuilder: https://github.com/eclipse-zenoh/zenoh/blob/main/zenoh/src/subscriber.rs#L303C12-L303C29
• AttachmentBuilder: https://github.com/eclipse-zenoh/zenoh/blob/main/zenoh/src/sample.rs#L115

@Mallets Just have a quick scan on these Builder. I'll add the Debug trait to those which haven't derived Debug trait.
BTW, do you think AttachmentBuilder should also derive Debug trait?

[Mallets]

@Mallets Just have a quick scan on these Builder. I'll add the Debug trait to those which haven't derived Debug trait. BTW, do you think AttachmentBuilder should also derive Debug trait?

Yes

[evshary]

@Mallets done