Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve project mangement (2) #696

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Improve project mangement (2) #696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1cece4a
feat: Add merged pull requests to release project
fuzzypixelz Jan 29, 2024
12280cc
fix: Missing string interpolation
fuzzypixelz Jan 29, 2024
6aee15e
fix: Workflow name too long
fuzzypixelz Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/enforce-linking-issues.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
script: |
const login = "${{ github.event.pull_request.user.login }}";
const syntaxUrl = "https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue";
const message = `@{login} If this pull request contains a bugfix or a new feature, then please consider using \`Closes #ISSUE-NUMBER\` [syntax](${syntaxUrl}) to link it to an issue.`
const message = `@${login} If this pull request contains a bugfix or a new feature, then please consider using \`Closes #ISSUE-NUMBER\` [syntax](${syntaxUrl}) to link it to an issue.`

github.rest.issues.createComment({
owner: context.repo.owner,
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sync-lockfiles.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Sync Cargo lockfile with Zenoh's dependants
name: Sync Cargo lockfiles

on:
schedule:
Expand Down
16 changes: 14 additions & 2 deletions .github/workflows/update-release-project.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ name: Update release project
on:
issues:
types: [opened, edited, labeled]
pull_request_target:
types: [closed]
branches:
- main
workflow_call:

defaults:
Expand Down Expand Up @@ -46,7 +50,8 @@ jobs:
core.info(`Using release project ${result}`)
return result;

- name: Is the issue author a contributor?
- if: ${{ github.event_name == 'issues' }}
name: Is the issue author a contributor?
id: author-is-contributor
uses: actions/github-script@v7
with:
Expand All @@ -67,10 +72,17 @@ jobs:
core.info(`Is the issue author ${login} a contributor? ${result}`);
return result;

- if: ${{ steps.author-is-contributor.outputs.result == 'true' }}
- if: ${{ github.event_name == 'issues' && steps.author-is-contributor.outputs.result == 'true' }}
name: Add issue to the release project if it has a release label
uses: actions/[email protected]
with:
github-token: ${{ secrets.BOT_TOKEN_WORKFLOW }}
project-url: ${{ steps.get-project-url.outputs.result }}
labeled: release

- if: ${{ github.event_name == 'pull_request_target' && github.event.pull_request.merged == 'true' }}
name: Add pull request to the release project
uses: actions/[email protected]
with:
github-token: ${{ secrets.BOT_TOKEN_WORKFLOW }}
project-url: ${{ steps.get-project-url.outputs.result }}