Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add interfaces to the Link #718

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Add interfaces to the Link #718

merged 2 commits into from
Feb 9, 2024

Conversation

sashacmc
Copy link
Member

@sashacmc sashacmc commented Feb 5, 2024

Add interfaces, which correspond to the address, to the Link.
This will allow interceptors to obtain information about the interface with which the message is associated.
Additionally, a small refactoring of the module std_only/net was made.

@eclipse-zenoh-bot
Copy link
Contributor

@sashacmc If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

@sashacmc sashacmc marked this pull request as ready for review February 5, 2024 15:37
@Mallets Mallets linked an issue Feb 5, 2024 that may be closed by this pull request
Interceptors configuration and attributes #663
Closed
4 tasks
Mallets
Mallets requested changes Feb 7, 2024
View reviewed changes
Copy link
Member

@Mallets Mallets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the minor comments I left regarding logging and comments.
Apart of that, it LGTM.

@sashacmc sashacmc force-pushed the add-interfaces-to-link branch from 92b148d to 8018f0d Compare February 7, 2024 16:19
@sashacmc sashacmc force-pushed the add-interfaces-to-link branch from 8018f0d to 97f021a Compare February 8, 2024 07:58
@sashacmc sashacmc force-pushed the add-interfaces-to-link branch from 97f021a to 65bcd17 Compare February 8, 2024 09:27
@Mallets Mallets linked an issue Feb 8, 2024 that may be closed by this pull request
Select endpoint to listen by interface name #691
Closed
@Mallets Mallets merged commit 8433384 into eclipse-zenoh:main Feb 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mallets Mallets Mallets approved these changes

Assignees

@sashacmc sashacmc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Select endpoint to listen by interface name Interceptors configuration and attributes
3 participants
@sashacmc @eclipse-zenoh-bot @Mallets