fix: Disable debug information in CI workflow #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mallets
approved these changes
Feb 23, 2024
jerry73204
pushed a commit
to NEWSLabNTU/zenoh
that referenced
this pull request
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #753.
By default rustc's
split-debuginfoisoffon Linux andpackedon macOS and Windows in Cargo'sdevprofile (essentially the configuration used for commands such ascargo build). Which means that on Linux debug information is included in the ELF binary while on macOS and Windows it's packed into a separate file. I'm not sure how this results in much larger debug information on Linux (the build size goes from > 20GB withdebuginfo=fullto < 5GB withdebuginfo=nonewhile it only decreases by 2-3GB for macOS and Windows).In any case, debug information is superfluous in CI, so this pull request simply disables it. This is rustc's default setting, but Cargo overrides it for "better user experience". Which only makes sense for dev boxes where a developer might want to run a debugger at any time.