-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to binding on the interface #755
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sashacmc
force-pushed
the
interface-binding
branch
from
February 23, 2024 17:59
2e2afd8
to
ebc9de1
Compare
sashacmc
force-pushed
the
interface-binding
branch
from
February 23, 2024 18:52
d881b5d
to
f252c7d
Compare
sashacmc
changed the title
Interface binding
Add possibility to binding on the interface
Feb 23, 2024
1 similar comment
Mallets
reviewed
Feb 26, 2024
Mallets
reviewed
Feb 26, 2024
Mallets
reviewed
Feb 26, 2024
Mallets
reviewed
Feb 26, 2024
Mallets
reviewed
Feb 26, 2024
Mallets
reviewed
Feb 26, 2024
Mallets
reviewed
Feb 26, 2024
Mallets
requested changes
Feb 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it LGTM. I've just left few minor comments that would lead to fewer memory allocations.
Mallets
approved these changes
Feb 27, 2024
jerry73204
pushed a commit
to NEWSLabNTU/zenoh
that referenced
this pull request
Mar 6, 2024
* Add test binding * Add binding to the interface * Add UDP support, fix windows/macos build * Add tests, fix windows build * Fix windows/macos builds * Move platfrom-related code to the zenoh-util * Remove unused dependencies * Add interface binding on connection * String usage refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add possibility to listen/connect for TCP/UDP connections on interface in place of (or together with) IP address.
Interface name provided via connection parameter
iface
.Also can be used for restrict connection for specific interface.
Samples:
tcp/0.0.0.0:7447#iface=wlan0
: Listen for tcp connection on any IP at thewlan0
interface, connections from other interfaces will be rejected.udp/192.168.0.1:7447#iface=eth0
: Listen for udp connection on specific IP at andeth0
interface, ifeth0
interface will be configured to other IP, connections will be rejected.udp/192.168.0.1:7447#iface=eth0
: Connect by udp with specific IP at andeth0
interface, ifeth0
interface will be configured to other IP, connections will be rejected.Closes #742