Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add connection retry #770

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Add connection retry #770

merged 1 commit into from
Mar 19, 2024

Conversation

sashacmc
Copy link
Member

@sashacmc sashacmc commented Feb 28, 2024 •
edited
Loading

  • Introduce connection retry config for listen and connect endpoints.
  • Listener initialisation reworked to add the connection retry.
  • Connection initialization reworked to be consistent with listening where it posible
  • Some configuration refactoring (ModeDependent related code moved to separate file)

@eclipse-zenoh-bot
Copy link
Contributor

@sashacmc If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

sashacmc
sashacmc commented Feb 28, 2024
View reviewed changes
commons/zenoh-config/src/lib.rs Outdated Show resolved Hide resolved
zenoh/src/net/runtime/orchestrator.rs Outdated Show resolved Hide resolved
zenoh/src/net/runtime/orchestrator.rs Outdated Show resolved Hide resolved
zenoh/src/net/runtime/orchestrator.rs Outdated Show resolved Hide resolved
@sashacmc sashacmc force-pushed the add-connection-retry branch from 0ba8b1c to 2f5eff2 Compare March 5, 2024 17:07
@sashacmc sashacmc changed the base branch from main to tokio-porting March 5, 2024 17:07
@eclipse-zenoh-bot
Copy link
Contributor

@sashacmc If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

@sashacmc sashacmc force-pushed the add-connection-retry branch 3 times, most recently from 14158a7 to 400f3fc Compare March 8, 2024 13:10
@sashacmc sashacmc marked this pull request as ready for review March 8, 2024 13:44
@eclipse-zenoh-bot
Copy link
Contributor

@sashacmc If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

@Mallets Mallets linked an issue Mar 8, 2024 that may be closed by this pull request
Support hot-pluggable serial USB ports #749
Closed
Mallets
Mallets reviewed Mar 8, 2024
View reviewed changes
DEFAULT_CONFIG.json5 Outdated Show resolved Hide resolved
Mallets
Mallets reviewed Mar 8, 2024
View reviewed changes
DEFAULT_CONFIG.json5 Outdated Show resolved Hide resolved
Mallets
Mallets reviewed Mar 8, 2024
View reviewed changes
DEFAULT_CONFIG.json5 Outdated Show resolved Hide resolved
OlivierHecart
OlivierHecart reviewed Mar 12, 2024
View reviewed changes
DEFAULT_CONFIG.json5 Outdated Show resolved Hide resolved
DEFAULT_CONFIG.json5 Outdated Show resolved Hide resolved
zenoh/src/net/runtime/orchestrator.rs Outdated Show resolved Hide resolved
commons/zenoh-config/src/connection_retry.rs Show resolved Hide resolved
@Mallets Mallets added the enhancement Existing things could work better label Mar 13, 2024
@sashacmc sashacmc requested a review from OlivierHecart March 13, 2024 23:43
OlivierHecart
OlivierHecart requested changes Mar 15, 2024
View reviewed changes
DEFAULT_CONFIG.json5 Outdated Show resolved Hide resolved
DEFAULT_CONFIG.json5 Outdated Show resolved Hide resolved
zenoh/src/net/runtime/orchestrator.rs Outdated Show resolved Hide resolved
@sashacmc sashacmc requested a review from OlivierHecart March 16, 2024 00:13
@OlivierHecart OlivierHecart changed the base branch from tokio-porting to main March 18, 2024 16:46
@sashacmc sashacmc force-pushed the add-connection-retry branch 2 times, most recently from c71f484 to 61e06eb Compare March 18, 2024 16:55
@sashacmc sashacmc force-pushed the add-connection-retry branch from 61e06eb to 05a3bb9 Compare March 19, 2024 09:07
Mallets
Mallets reviewed Mar 19, 2024
View reviewed changes
commons/zenoh-config/src/mode_dependend.rs Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type: the file should be called mode_dependent.

@Mallets Mallets enabled auto-merge (squash) March 19, 2024 13:34
@sashacmc
Add connection retry
6216719 
 - Introduce connection retry config for listen and connect endpoints.
 - Listener initialisation reworked to add the connection retry.
 - Connection initialization reworked to be consistent with listening where it posible
 - Some configuration refactoring (ModeDependent related code moved to separate file)
auto-merge was automatically disabled March 19, 2024 13:36

Head branch was pushed to by a user without write access

@sashacmc sashacmc force-pushed the add-connection-retry branch from b16af11 to 6216719 Compare March 19, 2024 13:36
@Mallets Mallets merged commit 7fc04e7 into eclipse-zenoh:main Mar 19, 2024
8 checks passed
@Mallets Mallets deleted the add-connection-retry branch March 19, 2024 14:48
@Mallets Mallets mentioned this pull request Apr 9, 2024
Closed
@JEnoch JEnoch mentioned this pull request Apr 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mallets Mallets Mallets approved these changes

@OlivierHecart OlivierHecart OlivierHecart approved these changes

Assignees

@sashacmc sashacmc

Labels
enhancement Existing things could work better
Projects
Zenoh 1.0.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support hot-pluggable serial USB ports
4 participants
@sashacmc @eclipse-zenoh-bot @OlivierHecart @Mallets