Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add express support #829

Merged
merged 4 commits into from
Mar 15, 2024
Merged

Add express support #829

merged 4 commits into from
Mar 15, 2024

Conversation

Mallets
Copy link
Member

@Mallets Mallets commented Mar 14, 2024 •
edited
Loading

@Mallets Mallets added the new feature Something new is needed label Mar 14, 2024
@eclipse-zenoh-bot
Copy link
Contributor

@Mallets If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

1 similar comment
@eclipse-zenoh-bot
Copy link
Contributor

@Mallets If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

@imstevenpmwork
Copy link
Contributor

@Mallets Can you link this to its relevant issue? If there's none, you can create one with the release template if this is meant to be included in the next release. Make sure also to add the proper timelines

@Mallets Mallets marked this pull request as ready for review March 14, 2024 14:26
@eclipse-zenoh-bot
Copy link
Contributor

@Mallets If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

@Mallets
Copy link
Member Author

Mallets commented Mar 14, 2024

@sashacmc would you mind reviewing it?

sashacmc
sashacmc reviewed Mar 14, 2024
View reviewed changes
Copy link
Member

@sashacmc sashacmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo and small question, other LGTM

examples/examples/z_ping.rs Show resolved Hide resolved
zenoh/src/sample.rs Outdated Show resolved Hide resolved
@Mallets Mallets merged commit 622b230 into protocol_changes Mar 15, 2024
15 checks passed
@Mallets Mallets deleted the protocol_express branch March 15, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sashacmc sashacmc sashacmc approved these changes

Assignees
No one assigned
Labels
new feature Something new is needed
Projects
Zenoh 1.0.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mallets @eclipse-zenoh-bot @imstevenpmwork @sashacmc