Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Liveliness implementation #865

Merged
merged 147 commits into from
Jun 18, 2024
Merged

Refactor Liveliness implementation #865

merged 147 commits into from
Jun 18, 2024

Conversation

fuzzypixelz
Copy link
Member

Resolves #864.

@eclipse-zenoh-bot
Copy link
Contributor

@fuzzypixelz If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

@fuzzypixelz fuzzypixelz marked this pull request as draft March 26, 2024 11:01
@fuzzypixelz fuzzypixelz changed the title Refactor/liveliness delaration Refactor Liveliness implementation Mar 26, 2024
@eclipse-zenoh-bot
Copy link
Contributor

@fuzzypixelz If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

@fuzzypixelz fuzzypixelz force-pushed the refactor/liveliness-delaration branch from dc9ec91 to 5b2ebbb Compare March 26, 2024 11:25
@fuzzypixelz fuzzypixelz changed the base branch from protocol_changes to client-interests March 26, 2024 11:27
@eclipse-zenoh-bot
Copy link
Contributor

@fuzzypixelz If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

@OlivierHecart OlivierHecart linked an issue Mar 26, 2024 that may be closed by this pull request
Protocol changes: Refactor Liveliness implementation #864
Closed
@OlivierHecart OlivierHecart self-requested a review March 26, 2024 11:49
@fuzzypixelz fuzzypixelz force-pushed the refactor/liveliness-delaration branch from fd7c307 to 8961ba3 Compare March 26, 2024 14:41
@OlivierHecart
Add client writer-side filtering (eclipse-zenoh#863)
cede672 
* Add client writer-side filtering

* Reimplement liveliness with interests

* Fix writer-side filtering before receiving FinalInterest
@OlivierHecart OlivierHecart deleted the branch eclipse-zenoh:dev/1.0.0 March 27, 2024 09:19
@OlivierHecart OlivierHecart reopened this Mar 27, 2024
@OlivierHecart OlivierHecart changed the base branch from client-interests to interests March 27, 2024 11:42
@fuzzypixelz fuzzypixelz force-pushed the refactor/liveliness-delaration branch from 8961ba3 to a3a9c7e Compare March 27, 2024 14:37
@fuzzypixelz
Copy link
Member Author

fuzzypixelz commented Mar 28, 2024 •
edited
Loading

What works now:

  1. Liveliness declaration, w/o the interest protocol, in brokered scenarios
  2. Liveliness get, w/o the interest protocol, in brokered scenarios

I disabled unused_variables and dead_code lints to unblock the CI.

@fuzzypixelz fuzzypixelz force-pushed the refactor/liveliness-delaration branch from 2e0afa9 to 3fcdb2c Compare March 28, 2024 17:05
@OlivierHecart OlivierHecart merged commit a5b4a65 into eclipse-zenoh:dev/1.0.0 Jun 18, 2024
11 checks passed
@Mallets Mallets mentioned this pull request Jul 4, 2024
Closed
This was referenced Jul 26, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mallets Mallets Mallets left review comments

@OlivierHecart OlivierHecart OlivierHecart approved these changes

Assignees

@fuzzypixelz fuzzypixelz

Labels
enhancement Existing things could work better internal Changes not included in the changelog
Projects
Zenoh 1.0.0 release
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Protocol changes: Refactor Liveliness implementation
4 participants
@fuzzypixelz @eclipse-zenoh-bot @OlivierHecart @Mallets