Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query.reply and reply_del, now accept TryIntoKeyExpr instead of IntoKeyExpr #878

Conversation

DenisBiryukov91
Copy link
Contributor

Query.reply and reply_del, now accept TryIntoKeyExpr instead of IntoKeyExpr

@eclipse-zenoh-bot
Copy link
Contributor

@DenisBiryukov91 If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

@Mallets Mallets merged commit 312c03a into eclipse-zenoh:protocol_changes Mar 29, 2024
9 checks passed
@milyin
Copy link
Contributor

milyin commented Mar 31, 2024

This change breaks merging of #858 where builders are reworked.
I'll keep this comment to not forget to restore this "TryIntoKeyExpr" functionality in #858

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants