Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to build zenoh without 'unstable' feature #910

Merged
merged 1 commit into from
Apr 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions zenoh/src/publication.rs
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@ impl<P> ValueBuilderTrait for PublicationBuilder<P, PublicationBuilderPut> {
}
}

#[zenoh_macros::unstable]
impl<P, T> SampleBuilderTrait for PublicationBuilder<P, T> {
#[cfg(feature = "unstable")]
fn source_info(self, source_info: SourceInfo) -> Self {
Expand Down
2 changes: 2 additions & 0 deletions zenoh/src/query.rs
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ pub struct GetBuilder<'a, 'b, Handler> {
pub(crate) source_info: SourceInfo,
}

#[zenoh_macros::unstable]
impl<Handler> SampleBuilderTrait for GetBuilder<'_, '_, Handler> {
#[cfg(feature = "unstable")]
fn source_info(self, source_info: SourceInfo) -> Self {
Expand Down Expand Up @@ -430,6 +431,7 @@ where
self.value,
#[cfg(feature = "unstable")]
self.attachment,
#[cfg(feature = "unstable")]
self.source_info,
callback,
)
Expand Down
12 changes: 10 additions & 2 deletions zenoh/src/queryable.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,15 @@ use crate::encoding::Encoding;
use crate::handlers::{locked, DefaultHandler};
use crate::net::primitives::Primitives;
use crate::prelude::*;
use crate::sample::{QoSBuilder, SourceInfo};
use crate::sample::builder::SampleBuilder;
use crate::sample::QoSBuilder;
#[cfg(feature = "unstable")]
use crate::sample::SourceInfo;
use crate::Id;
use crate::SessionRef;
use crate::Undeclarable;
#[cfg(feature = "unstable")]
use crate::{query::ReplyKeyExpr, sample::builder::SampleBuilder, sample::Attachment};
use crate::{query::ReplyKeyExpr, sample::Attachment};
use std::fmt;
use std::future::Ready;
use std::ops::Deref;
Expand Down Expand Up @@ -155,7 +158,9 @@ impl Query {
encoding: Encoding::default(),
},
timestamp: None,
#[cfg(feature = "unstable")]
source_info: SourceInfo::empty(),
#[cfg(feature = "unstable")]
attachment: None,
}
}
Expand Down Expand Up @@ -193,7 +198,9 @@ impl Query {
qos: response::ext::QoSType::RESPONSE.into(),
kind: ReplyBuilderDelete,
timestamp: None,
#[cfg(feature = "unstable")]
source_info: SourceInfo::empty(),
#[cfg(feature = "unstable")]
attachment: None,
}
}
Expand Down Expand Up @@ -298,6 +305,7 @@ impl<T> TimestampBuilderTrait for ReplyBuilder<'_, '_, T> {
}
}

#[cfg(feature = "unstable")]
impl<T> SampleBuilderTrait for ReplyBuilder<'_, '_, T> {
#[cfg(feature = "unstable")]
fn attachment<U: Into<Option<Attachment>>>(self, attachment: U) -> Self {
Expand Down
1 change: 1 addition & 0 deletions zenoh/src/sample/builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@ impl<T> TimestampBuilderTrait for SampleBuilder<T> {
}
}

#[cfg(feature = "unstable")]
impl<T> SampleBuilderTrait for SampleBuilder<T> {
#[zenoh_macros::unstable]
fn source_info(self, source_info: SourceInfo) -> Self {
Expand Down
8 changes: 4 additions & 4 deletions zenoh/src/sample/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ use crate::Priority;
#[zenoh_macros::unstable]
use serde::Serialize;
use std::{convert::TryFrom, fmt};
use zenoh_protocol::core::CongestionControl;
use zenoh_protocol::core::EntityGlobalId;
use zenoh_protocol::network::declare::ext::QoSType;
use zenoh_protocol::{core::CongestionControl, zenoh};

pub mod builder;

Expand Down Expand Up @@ -178,12 +178,12 @@ impl SourceInfo {
}

#[zenoh_macros::unstable]
impl From<SourceInfo> for Option<zenoh::put::ext::SourceInfoType> {
fn from(source_info: SourceInfo) -> Option<zenoh::put::ext::SourceInfoType> {
impl From<SourceInfo> for Option<zenoh_protocol::zenoh::put::ext::SourceInfoType> {
fn from(source_info: SourceInfo) -> Option<zenoh_protocol::zenoh::put::ext::SourceInfoType> {
if source_info.is_empty() {
None
} else {
Some(zenoh::put::ext::SourceInfoType {
Some(zenoh_protocol::zenoh::put::ext::SourceInfoType {
id: source_info.source_id.unwrap_or_default(),
sn: source_info.source_sn.unwrap_or_default() as u32,
})
Expand Down
6 changes: 5 additions & 1 deletion zenoh/src/session.rs
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ use zenoh_config::unwrap_or_default;
use zenoh_core::{zconfigurable, zread, Resolve, ResolveClosure, ResolveFuture, SyncResolve};
#[cfg(feature = "unstable")]
use zenoh_protocol::network::declare::SubscriberId;
#[cfg(feature = "unstable")]
use zenoh_protocol::network::ext;
use zenoh_protocol::network::AtomicRequestId;
use zenoh_protocol::network::RequestId;
use zenoh_protocol::zenoh::reply::ReplyBody;
Expand All @@ -77,7 +79,6 @@ use zenoh_protocol::{
subscriber::ext::SubscriberInfo, Declare, DeclareBody, DeclareKeyExpr, DeclareMode,
DeclareQueryable, DeclareSubscriber, UndeclareQueryable, UndeclareSubscriber,
},
ext,
request::{self, ext::TargetType, Request},
Mapping, Push, Response, ResponseFinal,
},
Expand Down Expand Up @@ -1687,7 +1688,10 @@ impl Session {
payload: RequestBody::Query(zenoh_protocol::zenoh::Query {
consolidation,
parameters: selector.parameters().to_string(),
#[cfg(feature = "unstable")]
ext_sinfo: source.into(),
#[cfg(not(feature = "unstable"))]
ext_sinfo: None,
ext_body: value.as_ref().map(|v| query::ext::QueryBodyType {
#[cfg(feature = "shared-memory")]
ext_shm: None,
Expand Down
3 changes: 0 additions & 3 deletions zenoh/src/subscriber.rs
Original file line number Diff line number Diff line change
Expand Up @@ -202,9 +202,6 @@ pub struct SubscriberBuilder<'a, 'b, Handler> {
#[cfg(not(feature = "unstable"))]
pub(crate) reliability: Reliability,

#[cfg(not(feature = "unstable"))]
pub(crate) mode: Mode,

#[cfg(feature = "unstable")]
pub origin: Locality,
#[cfg(not(feature = "unstable"))]
Expand Down
Loading