-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update from main
to protocol_changes
#924
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add manual resource clean up to Runtime::close(); - make certain task termination a bit cleaner;
…time, if there any active blocking tasks left
…re clarity; - Some tasks now terminate in more graceful way
- terminate more tasks - make TaskController::terminate_all[_async] accept timeout duration
…-pool Improve the drop of ZRUNTIME_POOL
Fix/memory leaks
* ci: Squash merge sync-lockfile prs, provide zenoh HEAD hash & date * fix: Add # before pull request number * fix: Set zenoh HEAD info in title
* Review tokio runtime being used * Fix cargo clippy
fix ZRuntimePool drop crash if not all runtimes were initialized
* Cancel query timeout task, once query is finalized * Add missing cargo.lock
* fix: Release workflow * fix: Remove enforce-linking-issues workflow
* fix: Add missing ghcr prefix in release workflow * fix: Set unpublished-deps-patterns to match all zenoh crates
* fix(913): using 2+batch.len() when increasing rx_bytes Signed-off-by: gabrik <[email protected]> * chore: format Signed-off-by: gabrik <[email protected]> --------- Signed-off-by: gabrik <[email protected]>
…ame_runtime Prevent session from closing external runtime on drop
As discussed internally, a reply to a query should not return an error when a key does not exist — this is a perfectly valid situation. In addition, this prevented the replication from correctly functioning: as an error was always returned by the storage that was actually looking for the data, other replies were not processed and that storage would thus never receive anything. * plugins/zenoh-plugin-storage-manager/src/replica/storage.rs: deleted the code replying an error to a query looking for a key the storage does not have. Signed-off-by: Julien Loudet <[email protected]>
merge `main` into `protocol changes`
…s_update2 Revert "merge `main` into `protocol changes`"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.