Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

[eclipse/xtext#2077] workaround for broken metadata in eclipse platform #1910

Closed
wants to merge 1 commit into from

Conversation

cdietrich
Copy link
Member

@cdietrich cdietrich commented Jun 15, 2022

[eclipse-xtext/xtext#2077] workaround for broken metadata in eclipse platform

@cdietrich cdietrich added this to the Release_2.28 milestone Jun 15, 2022
@LorenzoBettini
Copy link
Contributor

@cdietrich If I understand the problem correctly, this exclusion could be put in xtext.generator POM (actually gradle file, from which the POM is derived), similarly to what we did lately to pin platform dependency versions.

@cdietrich
Copy link
Member Author

@LorenzoBettini it seems the pin does not work if in the transitive hull there is stuff that does not exist at all.
i am not sure if there is something wrong on how we pin or in maven

@LorenzoBettini
Copy link
Contributor

@cdietrich I meant to put the exclusion itself in the POM of xtext.generator (not pinning a version; I was talking about pinning to recall what we did in the past). If we know which dependency X of xtext.generator tries to pull the org.osgi.service.prefs we can exclude that in correspondence of the dependency X, just like you did in the workaround.

Something similar to what I did here https://github.com/LorenzoBettini/edelta/blob/master/edelta.parent/edelta.maven.plugin/pom.xml#L33

@cdietrich
Copy link
Member Author

cdietrich commented Jun 15, 2022

@LorenzoBettini you mean

foreachdependency exclude all transitives via wildcard? is this possible? here the problem is maven seems to look at the broken preferences version although we pin it, and i dont understand why

@LorenzoBettini
Copy link
Contributor

@cdietrich I mean: if we find the dependency X that requires that non-existent dependency Y, we specify the dependency X with the exclusion of Y.
It's also possible to exclude via wildcard (https://stackoverflow.com/a/7556707/1930496) but I don't know if it's a good idea...

@cdietrich
Copy link
Member Author

yes, but i hope this pr will become obsolte with the platform fix and as said a preventive wildcard exclude might be a bad idea.

@cdietrich
Copy link
Member Author

cdietrich commented Jun 15, 2022

@LorenzoBettini does not looks so.
do you know if an exclustion would also work on bom level?

but it looks like gradle wont support it :(
gradle/gradle#12214

@LorenzoBettini
Copy link
Contributor

@cdietrich I'm expecting the exclusion to work at the BOM level: the idea of BOM and <dependencyManagement> is exactly to configure a dependency (and its exclusions) in one place only.

@cdietrich
Copy link
Member Author

Yes but gradle can’t do it as it seems

@LorenzoBettini
Copy link
Contributor

Another very good reason to ditch gradle for good.. ;)

@cdietrich
Copy link
Member Author

obsolete by removal of the bad artifact from maven central

@cdietrich cdietrich closed this Jun 17, 2022
@cdietrich cdietrich deleted the cd_workaround_xtext_issue2077 branch June 17, 2022 07:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants