Mixed support #2409
Open
Mixed support #2409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kchobantonov
commented
Dec 30, 2024
•
kchobantonov
commented
- provide support for mixed types
- fix clearing of inputs when not under an object - e.g. string once cleared will become empty string rather than to return undefined to remove the property from the parent object
- fix date controls, now the date can show year, year/month and etc. depending on the control option views
- improve the performance to convert dayjs format into maska format function
- fixing the :key to at least have the collection size into the key so when the size changes the vue will not reuse html elements leaving attributes like id unchanged
- add more examples to show how the mixed control can be used
- use arraySchema from the mapped values rather than using Resolve
- minor UI changes to use less space
- core changes : use the provided schema when the resolve failed, make sure that boolean is valid schema as well - e.g. items: true is valid schema (Note: the last change for the items to be boolean was reverted back since more code should be adjusted - maybe a future improvement)
…ot part of the object that has the property defined in properties then to not clear it - e.g. send undefined value
… based on index - e.g. prevent reusing elements when the array change size which will cause id properties for example to not have correct value
…tified for the new value
…n also allow such case to be handled by the object renderer
…s no need to resolve that schema just use it
…n the mixed renderer selected object type
❌ Deploy Preview for jsonforms-examples failed.
|
… in the core should be adjusted to handled that case
|
@sdirix please review - checkout the new examples
For example 3 the easier way to see that is to copy any example json data, provided it in the example ( Data tab - save it) and see the result in the Demo tab |
|
Thanks for the contribution ❤️ I'll take a look within January 👍 |
sdirix
reviewed
Feb 12, 2025
There was a problem hiding this comment.
Hi @kchobantonov,
I had a first look at the implementation. The examples work great and are really impressive ❤️
I added some comments, please have a look
packages/vue-vuetify/src/extended/AutocompleteEnumControlRenderer.vue
Outdated
Show resolved
Hide resolved
packages/vue-vuetify/src/extended/AutocompleteOneOfEnumControlRenderer.vue
Outdated
Show resolved
Hide resolved
packages/vue-vuetify/src/controls/AnyOfStringOrEnumControlRenderer.vue
Outdated
Show resolved
Hide resolved
|
@sdirix check my responses and also updated repo but it looks like the build failed perhaps because netlify is using greater than pnpm version 8 now ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.