Version 2.0.2

CHANGELOG.md

@@ -1,3 +1,9 @@
+# Version 2.0.2
+- Fix bug when running on PHP >= 7.1 and warning was raised when call `DOMDocument::schemaValidateSource`
+  making impossible to obtain errors from `libxml_clear_errors` and throw a new `LibXmlException`
+- Add a new test `SchemaValidatorTest::testValidateWithEmptySchema` to make sure that
+  a `LibXmlException` exception is raised
+
 # Version 2.0.1
 - Fix bug when using windows path (backslashs), it does not validate
 - Add docblock to buildSchemas

README.md

@@ -48,7 +48,7 @@ $schemas->create('http://example.org/schemas/x1', './local-schemas/x1.xsd');
 
 // validateWithSchemas does not return boolean, it throws an exception
 try {
-    $validator->validateWithSchemas($schemas));
+    $validator->validateWithSchemas($schemas);
 } catch (\XmlSchemaValidator\SchemaValidatorException $ex) {
     echo 'Found error: ' . $ex->getMessage();
 }

src/XmlSchemaValidator/LibXmlException.php

@@ -39,6 +39,8 @@ public static function throwFromLibXml()
      */
     public static function useInternalErrors(callable $callable)
     {
+        $previousErrorReporting = error_reporting();
+        error_reporting(0);
         $previousLibXmlUseInternalErrors = libxml_use_internal_errors(true);
         if ($previousLibXmlUseInternalErrors) {
             libxml_clear_errors();
@@ -47,6 +49,7 @@ public static function useInternalErrors(callable $callable)
         try {
             static::throwFromLibXml();
         } finally {
+            error_reporting($previousErrorReporting);
             libxml_use_internal_errors($previousLibXmlUseInternalErrors);
         }
         return $return;

src/XmlSchemaValidator/SchemaValidator.php

@@ -73,6 +73,7 @@ public function getLastError(): string
      *
      * @param Schemas $schemas
      * @return void
+     *
      * @throws LibXmlException if schema validation fails
      */
     public function validateWithSchemas(Schemas $schemas)

tests/XmlSchemaValidatorTests/SchemaValidatorTest.php

@@ -116,4 +116,18 @@ public function testValidateWithSchemasUsingLocal()
         $validator->validateWithSchemas($schemas);
         $this->assertTrue(true, 'validateWithSchemas did not throw any exception');
     }
+
+    public function testValidateWithEmptySchema()
+    {
+        $validator = $this->utilCreateValidator('books-valid.xml');
+        $schemas = new Schemas();
+        $schemas->create(
+            'http://test.org/schemas/books',
+            $this->utilAssetLocation('empty.xsd')
+        );
+
+        $this->expectException(SchemaValidatorException::class);
+        $this->expectExceptionMessage('Failed to parse the XML resource');
+        $validator->validateWithSchemas($schemas);
+    }
 }