-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIP updates #63
HIP updates #63
Conversation
MichaelSt98
commented
Dec 12, 2023
- adding arch files for LUMI CCE 16.0.1
- adding col/s as metric for HIP variants
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look sane to me, but I'll let @reuterbal check the LUMI configuration before merging. GTG from me though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks. HIP variants work perfectly as expected, and plain SCC still crashes the compiler, as expected.
But the OpenMP flags in the toolchain file aren't working for me as is. I've made a suggestion for a fix that I could build with successfully.
set( ENABLE_OMP ON CACHE STRING "" ) | ||
set( OpenMP_C_FLAGS "-homp" CACHE STRING "" ) | ||
set( OpenMP_Fortran_FLAGS "-homp -hnoacc -hlist=aimd -maxrregcount 64" CACHE STRING "" ) | ||
|
||
#################################################################### | ||
# OpenACC FLAGS | ||
#################################################################### | ||
|
||
set( ENABLE_ACC ON CACHE STRING "" ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't -maxrregcount 64 an NVHPC compiler option? It didn't work for me with CCE.
Also, there's the usual OpenMP library lookup failure that we know from IFS. The following options work, though:
set( ENABLE_OMP ON CACHE STRING "" ) | |
set( OpenMP_C_FLAGS "-homp" CACHE STRING "" ) | |
set( OpenMP_Fortran_FLAGS "-homp -hnoacc -hlist=aimd -maxrregcount 64" CACHE STRING "" ) | |
#################################################################### | |
# OpenACC FLAGS | |
#################################################################### | |
set( ENABLE_ACC ON CACHE STRING "" ) | |
set( OpenMP_C_FLAGS "-fopenmp" ) | |
set( OpenMP_CXX_FLAGS "-fopenmp" ) | |
set( OpenMP_Fortran_FLAGS "-fopenmp" ) | |
set( OpenMP_C_LIB_NAMES "craymp" ) | |
set( OpenMP_CXX_LIB_NAMES "craymp" ) | |
set( OpenMP_Fortran_LIB_NAMES "craymp" ) | |
set( OpenMP_craymp_LIBRARY "/opt/cray/pe/cce/16.0.1/cce/x86_64/lib/libcraymp.so" ) | |
#################################################################### | |
# OpenACC FLAGS | |
#################################################################### | |
Thanks! I can confirm that all variants build now. Unfortunately, the env file still doesn't quite work for me:
Would you mind fixing 1 and briefly investigating 2? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for figuring out the missing offload. Still some problems with the env file, at least when I've tried it, but a suggested solution that worked for me.
Co-authored-by: Balthasar Reuter <[email protected]>
Just double-checked your proposed changes and committed them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, many thanks. Going in