Fix memory issues found using Valgrind ECFLOW-1969 #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## hotfix/5.13.4 #114 +/- ##
================================================
Coverage ? 47.07%
================================================
Files ? 1179
Lines ? 93309
Branches ? 14744
================================================
Hits ? 43928
Misses ? 49381
Partials ? 0 ☔ View full report in Codecov by Sentry. |
sandorkertesz
approved these changes
Sep 2, 2024
marcosbento
force-pushed
the
hotfix/5.13.4
branch
from
37c6818 to
57fde12
Compare
marcosbento
force-pushed
the
hotfix/memory_fixes
branch
from
8138614 to
68b3534
Compare
Re ECFLOW-1969
Re ECFLOW-1969
Re ECFLOW-1969
This is achieved by storing the Expression's AST in a managed pointer (i.e. std::unique_ptr) Re ECFLOW-1969
Re ECFLOW-1969
Re ECFLOW-1969
This effectively replaces the use of a raw pointer with a managed pointer (i.e. std::unique_ptr) Re ECFLOW-1969
Re ECFLOW-1969
This is achieved by creating a statically allocated cache object that manages the definitions, and automatically releases them when closing the application. Re ECFLOW-1969
Re ECFLOW-1969
This prevents a use after deletion, since clearInternal() calls VReply::resets(). Re ECFLOW-1969
This guarantees source code onsistency as copy/move ctors are also deleted. Re ECFLOW-1969
marcosbento
force-pushed
the
hotfix/memory_fixes
branch
from
68b3534 to
57ca7d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.