Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use io_context instead of the deprecated io_service #115

Closed
wants to merge 1 commit into from

Conversation

marcosbento
Copy link
Collaborator

  • User boost::asio::bind_executor instead of the deprecated io_service::wrap()

Re ECFLOW-1973

- User boost::asio::bind_executor instead of the deprecated io_service::wrap()

Re ECFLOW-1973
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 70.83333% with 21 lines in your changes missing coverage. Please review.

Project coverage is 47.09%. Comparing base (ba31be4) to head (8eb08f0).

Files with missing lines Patch % Lines
libs/client/src/ecflow/client/ClientInvoker.cpp 50.00% 3 Missing ⚠️
libs/server/src/ecflow/server/SslTcpServer.cpp 0.00% 3 Missing ⚠️
libs/udp/src/ecflow/udp/UDPServer.hpp 0.00% 3 Missing ⚠️
libs/base/src/ecflow/base/SslClient.cpp 0.00% 2 Missing ⚠️
libs/base/src/ecflow/base/cts/user/PlugCmd.cpp 60.00% 2 Missing ⚠️
libs/base/src/ecflow/base/ssl_connection.cpp 0.00% 2 Missing ⚠️
libs/server/src/ecflow/server/CheckPtSaver.cpp 60.00% 2 Missing ⚠️
libs/server/src/ecflow/server/ServerMain.cpp 71.42% 2 Missing ⚠️
libs/server/src/ecflow/server/SslServer.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #115      +/-   ##
===========================================
- Coverage    47.13%   47.09%   -0.04%     
===========================================
  Files         1180     1180              
  Lines        93286    93288       +2     
  Branches     14743    14743              
===========================================
- Hits         43970    43934      -36     
- Misses       49316    49354      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcosbento marcosbento closed this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants