Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General improvement of tests #122

Merged
merged 14 commits into from
Sep 20, 2024
Merged

General improvement of tests #122

merged 14 commits into from
Sep 20, 2024

Conversation

marcosbento
Copy link
Collaborator

@marcosbento marcosbento commented Sep 18, 2024

  • Apply consistent format to tests name (i.e. output shown at runtime)
  • Reduce the number of direct uses of std::cout in test implementation

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 80.75949% with 152 lines in your changes missing coverage. Please review.

Project coverage is 47.15%. Comparing base (d7abfaf) to head (51f2ff1).

Files with missing lines Patch % Lines
libs/test/TestZombies.cpp 0.00% 19 Missing ⚠️
libs/core/test/TestStr.cpp 37.93% 18 Missing ⚠️
libs/test/TestWhyCmd.cpp 0.00% 12 Missing ⚠️
libs/core/test/TestLog.cpp 50.00% 10 Missing ⚠️
libs/core/test/TestSanitizerUB.cpp 52.94% 8 Missing ⚠️
libs/test/TestTime.cpp 0.00% 7 Missing ⚠️
libs/core/test/TestNodePath.cpp 40.00% 6 Missing ⚠️
libs/core/test/TestSanitizerAS.cpp 50.00% 6 Missing ⚠️
libs/test/TestRepeat.cpp 0.00% 6 Missing ⚠️
libs/core/test/TestCalendar.cpp 75.00% 4 Missing ⚠️
... and 32 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #122      +/-   ##
===========================================
+ Coverage    47.07%   47.15%   +0.07%     
===========================================
  Files         1179     1181       +2     
  Lines        93310    93472     +162     
  Branches     14744    14736       -8     
===========================================
+ Hits         43929    44078     +149     
- Misses       49381    49394      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcosbento marcosbento force-pushed the feature/format_test_name branch 3 times, most recently from d1d549a to 7d88776 Compare September 18, 2024 15:48
@marcosbento marcosbento force-pushed the feature/format_test_name branch from 7d88776 to 55fb27c Compare September 19, 2024 09:48
@marcosbento marcosbento changed the title Consistently format tests name General improvement of tests Sep 20, 2024
@marcosbento marcosbento marked this pull request as ready for review September 20, 2024 12:43
@marcosbento marcosbento merged commit b7e9139 into develop Sep 20, 2024
96 checks passed
@marcosbento marcosbento deleted the feature/format_test_name branch September 20, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants