Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General improvement to Environment Variables access #123

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

marcosbento
Copy link
Collaborator

  • Concentrate the Environment Variables under a single API specified at ecflow/core/Environment.hpp
  • Replace all raw calls to ::getenv()

Re ECFLOW-1957

- Concentrate the Environment Variables under a single API
  specified at ecflow/core/Environment.hpp
- Replace all raw calls to ::getenv()

Re ECFLOW-1957
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 83.43023% with 57 lines in your changes missing coverage. Please review.

Project coverage is 47.12%. Comparing base (b7e9139) to head (fca83b6).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
libs/client/test/SCPort.cpp 43.75% 9 Missing ⚠️
libs/test/src/TestFixture.cpp 0.00% 7 Missing ⚠️
libs/client/test/TestSinglePerf.cpp 0.00% 5 Missing ⚠️
libs/test/TestClkSync.cpp 0.00% 5 Missing ⚠️
libs/base/src/ecflow/base/cts/user/CFileCmd.cpp 50.00% 4 Missing ⚠️
...ibs/client/src/ecflow/client/ClientEnvironment.cpp 82.35% 3 Missing ⚠️
libs/node/src/ecflow/node/JobCreationCtrl.cpp 40.00% 3 Missing ⚠️
libs/node/src/ecflow/node/Submittable.cpp 83.33% 3 Missing ⚠️
libs/core/src/ecflow/core/Environment.hpp 92.59% 2 Missing ⚠️
libs/node/test/TestEcfFile.cpp 95.65% 2 Missing ⚠️
... and 12 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #123      +/-   ##
===========================================
- Coverage    47.15%   47.12%   -0.03%     
===========================================
  Files         1181     1182       +1     
  Lines        93472    93344     -128     
  Branches     14736    14706      -30     
===========================================
- Hits         44078    43992      -86     
+ Misses       49394    49352      -42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcosbento marcosbento marked this pull request as ready for review September 23, 2024 10:09
@marcosbento marcosbento merged commit fca83b6 into develop Sep 23, 2024
96 checks passed
@marcosbento marcosbento deleted the feature/improve_env_vars_access branch September 23, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants