Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct enable/disable of session dialog buttons ECFLOW-1980 #128

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

marcosbento
Copy link
Collaborator

No description provided.

- Remove unnecessary Label in Clone/Update Session dialog

Re ECFLOW-1980
@marcosbento
Copy link
Collaborator Author

@iainrussell @sandorkertesz

The button selection should now be working on both the local machine (Qt6) and in the HPC (Qt5).
Can you please give it a try on your side?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Please upload report for BASE (hotfix/5.13.5@7e32bc0). Learn more about missing BASE report.

Files with missing lines Patch % Lines
Viewer/ecflowUI/src/SessionDialog.cpp 0.00% 5 Missing ⚠️
Viewer/ecflowUI/src/SessionHandler.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             hotfix/5.13.5     #128   +/-   ##
================================================
  Coverage                 ?   48.48%           
================================================
  Files                    ?     1179           
  Lines                    ?    97553           
  Branches                 ?    14756           
================================================
  Hits                     ?    47297           
  Misses                   ?    50256           
  Partials                 ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iainrussell
Copy link
Member

It's working well for me :)

@marcosbento marcosbento marked this pull request as ready for review October 31, 2024 14:46
@marcosbento marcosbento merged commit b17cebc into hotfix/5.13.5 Oct 31, 2024
99 checks passed
@marcosbento marcosbento deleted the fix/enabling_session_dialog_button branch October 31, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants