Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable editing and show progress for Repeat DateTime ECFLOW-1988 #135

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

marcosbento
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 81.89845% with 82 lines in your changes missing coverage. Please review.

Please upload report for BASE (hotfix/5.13.6@2ab568b). Learn more about missing BASE report.

Files with missing lines Patch % Lines
Viewer/ecflowUI/src/VRepeatAttr.cpp 0.00% 29 Missing ⚠️
Viewer/ecflowUI/src/RepeatEditor.cpp 0.00% 25 Missing ⚠️
...ibs/attribute/src/ecflow/attribute/RepeatRange.hpp 74.35% 20 Missing ⚠️
libs/attribute/src/ecflow/attribute/RepeatAttr.hpp 37.50% 5 Missing ⚠️
Viewer/ecflowUI/src/NodeViewDelegate.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             hotfix/5.13.6     #135   +/-   ##
================================================
  Coverage                 ?   48.84%           
================================================
  Files                    ?     1184           
  Lines                    ?    98254           
  Branches                 ?    14778           
================================================
  Hits                     ?    47996           
  Misses                   ?    50258           
  Partials                 ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@marcosbento marcosbento marked this pull request as ready for review November 22, 2024 13:36
@marcosbento marcosbento merged commit 374e6d8 into hotfix/5.13.6 Nov 22, 2024
101 checks passed
@marcosbento marcosbento deleted the fix/repeat_progress_and_editing branch November 22, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants