Create abstraction around conversion facilities ECFLOW-1922 #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcosbento
force-pushed
the
feature/type_conversion_wrapper
branch
from
3f12ac8
to
07b347e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #45 +/- ##
===========================================
- Coverage 80.17% 80.14% -0.03%
===========================================
Files 575 577 +2
Lines 57874 57855 -19
===========================================
- Hits 46399 46367 -32
- Misses 11475 11488 +13
☔ View full report in Codecov by Sentry. |
marcosbento
force-pushed
the
feature/type_conversion_wrapper
branch
2 times, most recently
from
f268433
to
07b347e
Compare
marcosbento
changed the title
These changes create a thin layer wrapper for conversions between basic types (e.g. std::string, int), allowing to encapsulate all uses of boost::lexical_cast. Re ECFLOW-1922
Re ECFLOW-1922
These changes allow the user to introduce a template specialization converter_traits<From, To> thus specifying an additional conversion to be considered overall. Re ECFLOW-1922
Global qualifier in struct/class name definition is accepted by Clang but not allowed in GCC (which apparently doesn't implement the correction of the C++ Core Issue 355, see https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2011/n3259.htm). Removing the global qualifier solved the issue. Re ECFLOW-1922
marcosbento
force-pushed
the
feature/type_conversion_wrapper
branch
from
07b347e
to
8c6d2b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes create a thin layer wrapper for conversions between basic types (e.g. std::string, int), allowing to encapsulate all uses of boost::lexical_cast.