-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize CMakeLists.txt ECFLOW-1923 #49
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #49 +/- ##
========================================
Coverage 83.55% 83.55%
========================================
Files 539 539
Lines 52524 52525 +1
========================================
+ Hits 43884 43886 +2
+ Misses 8640 8639 -1
☔ View full report in Codecov by Sentry. |
marcosbento
changed the title
Modernize CMakeLists.txt
Modernize CMakeLists.txt ECFLOW-1923
Oct 31, 2023
marcosbento
force-pushed
the
feature/modernise_cmake
branch
from
November 13, 2023 09:24
def30a5
to
f2d6c46
Compare
- Move generated header files to CMAKE_BINARY_DIR to avoid having changes on the working directory (dirty repository) - Setup Boost.unit_test_framework as header only library - Create a specific entry point for the test driver - by convention, named Test<LibName>_main.cpp
marcosbento
force-pushed
the
feature/modernise_cmake
branch
from
November 13, 2023 10:06
f2d6c46
to
bef19e4
Compare
marcosbento
force-pushed
the
feature/modernise_cmake
branch
6 times, most recently
from
November 13, 2023 15:48
5864b78
to
d4214b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modernize CMakeLists.txt for Core