Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize CMakeLists.txt ECFLOW-1923 #49

Merged
merged 13 commits into from
Nov 13, 2023
Merged

Conversation

marcosbento
Copy link
Collaborator

Modernize CMakeLists.txt for Core

  • Move generated header files to CMAKE_BINARY_DIR to avoid having changes on the working directory (dirty repository)
  • Setup Boost.unit_test_framework as header only library
  • Create a specific entry point for the test driver
    • by convention, named Test_main.cpp

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a300b98) 83.55% compared to head (aa7c5f8) 83.55%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #49   +/-   ##
========================================
  Coverage    83.55%   83.55%           
========================================
  Files          539      539           
  Lines        52524    52525    +1     
========================================
+ Hits         43884    43886    +2     
+ Misses        8640     8639    -1     
Files Coverage Δ
ACore/test/TestFile.cpp 99.10% <ø> (ø)
ACore/test/TestNodePath.cpp 92.72% <ø> (ø)
ANattr/test/TestAttrSerialization.cpp 100.00% <ø> (ø)
ANode/parser/test/TestParser.cpp 91.01% <ø> (+0.10%) ⬆️
ANode/test/TestExprParser.cpp 98.16% <ø> (ø)
Base/test/TestResolveDependencies.cpp 100.00% <ø> (ø)
CSim/test/TestSimulator.cpp 91.17% <ø> (ø)
Client/test/TestClientEnvironment.cpp 100.00% <ø> (ø)
Http/test/TestApiV1.cpp 95.49% <ø> (ø)
Server/test/TestServerEnvironment.cpp 96.79% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcosbento marcosbento changed the title Modernize CMakeLists.txt Modernize CMakeLists.txt ECFLOW-1923 Oct 31, 2023
- Move generated header files to CMAKE_BINARY_DIR to avoid having
  changes on the working directory (dirty repository)
- Setup Boost.unit_test_framework as header only library
- Create a specific entry point for the test driver
  - by convention, named Test<LibName>_main.cpp
@marcosbento marcosbento deleted the feature/modernise_cmake branch November 13, 2023 10:07
@marcosbento marcosbento restored the feature/modernise_cmake branch November 13, 2023 10:07
@marcosbento marcosbento reopened this Nov 13, 2023
@marcosbento marcosbento force-pushed the feature/modernise_cmake branch 6 times, most recently from 5864b78 to d4214b5 Compare November 13, 2023 15:48
@marcosbento marcosbento merged commit 3fca261 into develop Nov 13, 2023
48 checks passed
@marcosbento marcosbento deleted the feature/modernise_cmake branch November 13, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants