Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce dependency on Boost string_view/algorithms ECFLOW-1922 #61

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

marcosbento
Copy link
Collaborator

No description provided.

These changes allow to more easily replace the use of
Boost capabilities, by wrapping otherwise scattered and direct uses
of boost::join/replace_first/split/starts_with/trim.

Re ECFLOW-1922
@marcosbento marcosbento force-pushed the feature/boost_clean_up_algorithm branch from 5083d9d to e39fc77 Compare November 17, 2023 15:55
@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (f2dea78) 80.16% compared to head (e39fc77) 83.54%.

Files Patch % Lines
ACore/src/StringSplitter.cpp 84.61% 2 Missing ⚠️
ANode/src/ExprParser.cpp 92.30% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #61      +/-   ##
===========================================
+ Coverage    80.16%   83.54%   +3.38%     
===========================================
  Files          578      542      -36     
  Lines        57912    52520    -5392     
===========================================
- Hits         46427    43880    -2547     
+ Misses       11485     8640    -2845     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcosbento marcosbento merged commit c00afce into develop Nov 17, 2023
47 checks passed
@marcosbento marcosbento deleted the feature/boost_clean_up_algorithm branch November 17, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants