Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Boost dependencies ECFLOW-1922 #62

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Conversation

marcosbento
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (d3a0556) 83.50% compared to head (c7f2ad3) 80.16%.

Files Patch % Lines
ACore/src/ecflow/core/File.cpp 33.33% 4 Missing ⚠️
ANode/src/ecflow/node/Memento.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #62      +/-   ##
===========================================
- Coverage    83.50%   80.16%   -3.35%     
===========================================
  Files          544      580      +36     
  Lines        52532    57925    +5393     
===========================================
+ Hits         43869    46434    +2565     
- Misses        8663    11491    +2828     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcosbento marcosbento force-pushed the feature/reduce_boost branch 2 times, most recently from 818c201 to c7f2ad3 Compare December 1, 2023 18:20
The intent is to minimize the uses of Boost.filesystem throughout the code base, and eventually facilitate replacement with std::filesystem.

Re ECFLOW-1922
By explicitly declaring copy/move ctors (and related copy/move assignment operators) we avoid the need to inherit from boost::noncopyable.

Re ECFLOW-1922
@marcosbento marcosbento merged commit 6689ac7 into develop Dec 1, 2023
47 checks passed
@marcosbento marcosbento deleted the feature/reduce_boost branch December 1, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants