Improve mapping between enum value and designation ECFLOW-1931 #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcosbento
force-pushed
the
feature/reduce_code_duplication
branch
2 times, most recently
from
f70056f
to
641d655
Compare
The goals behind these changes is to create a structure that holds the mapping between enum value and the corresponding designation, and then use it to make conversions. This approach avoids needless source code repetition (including repeated designation values), and allows to easily support new enum values/designation, by simply adding new entries to the mapping table. Re ECFLOW-1931
marcosbento
force-pushed
the
feature/reduce_code_duplication
branch
from
641d655
to
88e9f3e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #69 +/- ##
===========================================
+ Coverage 80.17% 83.53% +3.35%
===========================================
Files 625 590 -35
Lines 57957 52438 -5519
===========================================
- Hits 46466 43803 -2663
+ Misses 11491 8635 -2856 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.