feat (settings): Verification grid level default settings for spectrograms #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hudson-newey
changed the title
hudson-newey
added
stakeholder-P
stakeholder-D
stakeholder-S
enhancement
hudson-newey
commented
Feb 6, 2025
Comment on lines
+163
to
+186
| public set defaultSpectrogramOptions(options: SpectrogramOptions) { | ||
| // TODO: make this a lot better | ||
| const currentOptions = this.spectrogramOptions; | ||
| const currentDefaults = this.defaultOptions; | ||
| const newOptions = currentOptions; | ||
|
|
||
| const newOptionEntries = Object.entries(options); | ||
|
|
||
| for (const [key, value] of newOptionEntries) { | ||
| if ((options as any)[key] === (currentDefaults as any)[key]) { | ||
| continue; | ||
| } | ||
|
|
||
| const isDefault = (currentDefaults as any)[key] === (currentOptions as any)[key]; | ||
| if (isDefault) { | ||
| console.debug(`Setting default option ${key} to ${value}`); | ||
| (newOptions as any)[key] = value; | ||
| } else { | ||
| (newOptions as any)[key] = (currentOptions as any)[key]; | ||
| } | ||
| } | ||
|
|
||
| this.defaultOptions = options; | ||
| this.spectrogramOptions = newOptions; |
There was a problem hiding this comment.
The typing here is really poor, I should improve it
hudson-newey
changed the title
atruskie
requested changes
Feb 6, 2025
There was a problem hiding this comment.
We need to talk about the architecture of this. What is problematic is the change cycle seems to be running through the media controls
For each component that uses settings, I expect to see:
- subscription to a signal
- on signal:
currentSettings = Object.assign({}, this.defaultSettings, this.globalSettings, this.attributeSettings
OR, each individual setting is a signal:
e.g. windowSize : Signal<integer> = settingHelper(nameof(windowSize))
implementation is something like
coalesce(this[propertyName], this.globalSettings.value()[propertyName])
Comment on lines
+188
to
+195
| const spectrogramOptionsSignal = signal<SpectrogramOptions>(this.spectrogramElement.spectrogramOptions); | ||
| spectrogramOptionsSignal.subscribe((newOptions) => { | ||
| if (!this.spectrogramElement) { | ||
| throw new Error( | ||
| "No spectrogram element found. This might be because you forgot to unsubscribe from the options signal", | ||
| ); | ||
| } | ||
| this.spectrogramElement.spectrogramOptions = newOptions; |
There was a problem hiding this comment.
this seems to be a recursive definition.
but also, why is it the job of media controls to set the options on a spectrogram?
Comment on lines
+198
to
+206
| const axesOptionsSignal = signal<AxesOptions>(this.axesElement.axesOptions); | ||
| axesOptionsSignal.subscribe((newOptions) => { | ||
| if (!this.axesElement) { | ||
| throw new Error( | ||
| "No axes element found. This might be because you forgot to unsubscribe from the options signal", | ||
| ); | ||
| } | ||
| this.axesElement.axesOptions = newOptions; | ||
| }); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat (settings): Verification grid level default settings for spectrograms
Changes
Remaining Bugs / Unresolved Problems
Visual Changes
Related Issues
Fixes: #179
Final Checklist
pnpm lintruns without any errorspnpm testruns without any errors