fix(CI): various minor changes for satisfying CI #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkafar
commented
Oct 9, 2023
| @@ -358,6 +358,7 @@ impl PartialEq for JsspIndividual { | |||
| impl Eq for JsspIndividual {} | |||
|
|
|||
| impl PartialOrd for JsspIndividual { | |||
| #[allow(clippy::incorrect_partial_ord_impl_on_ord_type)] | |||
There was a problem hiding this comment.
This lint is useless in our case, as we use PartialOrd impl in Ord impl.
There was a problem hiding this comment.
We can't really do this the other way around
examples/jssp/problem/probe.rs
Outdated
Comment on lines
121
to
132
| if a.finish_time < b.finish_time { | ||
| Ordering::Less | ||
| } else if a.finish_time > b.finish_time { | ||
| Ordering::Greater | ||
| } else if a.duration != 0 && b.duration != 0 { | ||
| a.machine.cmp(&b.machine) | ||
| } else if a.duration != 0 && b.duration == 0 { | ||
| Ordering::Less | ||
| } else { | ||
| return Ordering::Greater; | ||
| Ordering::Greater | ||
| } | ||
| }); |
There was a problem hiding this comment.
Not sure what should happen when:
- finish times are equal and both durations are 0
- finish times are equal and both durations are not equal and not 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked issues
Important implementation details