Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.4.0 #28

Merged
merged 64 commits into from
Dec 16, 2021
Merged

v0.4.0 #28

merged 64 commits into from
Dec 16, 2021

Conversation

Paebbels
Copy link
Member

@Paebbels Paebbels commented Nov 1, 2021

New Features

Changes

  • Update logo, banner and favicon.
  • Documentation:
    • Fall back to alabaster if _theme is not available.
    • Cleanup requirements.txt.
    • Update shields/badges and reorganized them.
    • Add ref to EDAA site through a toctree.
  • README:
    • Reorganized content and updated shields/badges.
  • Using new pipeline workflow based on pyTooling/Actions.
  • Update/rework requirements files.
  • Using pyTooling.Packaging in conf.py and setup.py.
  • Reworked and documented dependencies.
  • Changed decorator export from pydecor to pyTooling.Decorators.
  • Updated dependencies after merging pyTooling.Packaging into pyTooling.
  • Updated workflow after changing Python code packaging to use build.
  • Added pyproject.toml.
  • Using __keywords__ variable for packaging.

Bug Fixes

  • Fixed documentation generation with BuildTheDocs

Closes #36.

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@752077b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #28   +/-   ##
=======================================
  Coverage        ?   82.85%           
=======================================
  Files           ?        9           
  Lines           ?     1476           
  Branches        ?      236           
=======================================
  Hits            ?     1223           
  Misses          ?      192           
  Partials        ?       61           
Flag Coverage Δ
unittests 82.85% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 752077b...ebf46ad. Read the comment docs.

@Paebbels
Copy link
Member Author

Paebbels commented Dec 13, 2021

@umarcor installing with python setup.py . is quite a problem as we don't have some dependencies available.

See https://github.com/edaa-org/pyEDAA.ProjectModel/runs/4500396973?check_suite_focus=true#step:4:17
image

Any ideas how to solve it?

@umarcor
Copy link
Member

umarcor commented Dec 13, 2021

Maybe pip install .?

@Paebbels
Copy link
Member Author

I checked, this is already used.

@umarcor
Copy link
Member

umarcor commented Dec 15, 2021

Blocked by pyTooling/Actions#20.

EDIT

See pyTooling/Actions#21.

@umarcor umarcor marked this pull request as ready for review December 16, 2021 06:44
@umarcor umarcor marked this pull request as draft December 16, 2021 06:45
@umarcor
Copy link
Member

umarcor commented Dec 16, 2021

pyTooling/Actions#21 was merged and this is now green. Keeping it as a draft until we update the installation of pyTooling.Packaging.

@Paebbels Paebbels requested a review from umarcor December 16, 2021 10:48
@umarcor umarcor marked this pull request as ready for review December 16, 2021 19:06
Copy link
Member

@umarcor umarcor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@umarcor umarcor added the Enhancement New feature or request label Dec 16, 2021
@Paebbels Paebbels merged commit 736a5dd into main Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

Add a UnitTesting report publishing job
3 participants