Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use reusable workflows from pyTooling/Actions #18

Merged
merged 15 commits into from
Dec 1, 2021
Merged

Conversation

umarcor
Copy link
Member

@umarcor umarcor commented Nov 28, 2021

In this PR, the CI Pipeline is reworked in order to use reusable workflows from pyTooling/Actions (see pyTooling/Actions#1).

Each job is replaced with a call to a reusable workflow.

As explained in VHDL/pyVHDLModel#36, the logic for dealing with global parameters is changed.

MPORTANT: reusable workflows must be used through an absolute name and specifying a version (see actions/runner#1493). Therefore, this PR will be kept as a draft, because s/@dev/@main/ is required in Pipeline.yml before merging.

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2021

Codecov Report

Merging #18 (25863a6) into dev (b7c2f61) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev      #18   +/-   ##
=======================================
  Coverage   69.23%   69.23%           
=======================================
  Files           2        2           
  Lines          91       91           
  Branches       10       10           
=======================================
  Hits           63       63           
  Misses         27       27           
  Partials        1        1           
Flag Coverage Δ
unittests 69.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7c2f61...25863a6. Read the comment docs.

@umarcor umarcor marked this pull request as ready for review November 30, 2021 23:50
@umarcor
Copy link
Member Author

umarcor commented Nov 30, 2021

@Paebbels, this is ready for review. I applied the same enhancements as in edaa-org/pyEDAA.ProjectModel#31.

@Paebbels Paebbels merged commit abdbe49 into dev Dec 1, 2021
@Paebbels Paebbels deleted the ci-pyactions branch December 1, 2021 06:29
@umarcor umarcor added the Enhancement New feature or request label Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants