Skip to content

Commit

Permalink
Updated links to other browsers
Browse files Browse the repository at this point in the history 
- Commented out AberOWL, as it's outdated and contains some weirdness in concept attributes
- Changed WebProtégé link to the "dev" version
- Added notes on what versions are displayed
  • Loading branch information
@matuskalas
matuskalas authored Aug 4, 2021
1 parent e0c46af commit d127208
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions js/tree-edam-stand-alone.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -472,13 +472,13 @@ function interactive_edam_browser(){
if(uri.startsWith("http://edamontology.org/")){
append_row(community,"Links",
"Open in "+
"<a target=\"_blank\" href=\"http://aber-owl.net/ontology/EDAM/#/Browse/%3Chttp%3A%2F%2Fedamontology.org%2F"+identifier+"%3E\">AberOWL</a>"+
/*"<a target=\"_blank\" href=\"http://aber-owl.net/ontology/EDAM/#/Browse/%3Chttp%3A%2F%2Fedamontology.org%2F"+identifier+"%3E\">AberOWL</a>"+
", "+*/
"<a target=\"_blank\" href=\"http://bioportal.bioontology.org/ontologies/EDAM/?p=classes&conceptid="+uri+"\">BioPortal</a> (newest \"unstable\")"+
", "+
"<a target=\"_blank\" href=\"http://bioportal.bioontology.org/ontologies/EDAM/?p=classes&conceptid="+uri+"\">BioPortal</a>"+

This comment has been minimized.

Sign in to view

Copy link
@matuskalas

matuskalas Aug 4, 2021

Author Member

Wouldn't it be better here to insert identifier instead of uri?
I remember there was a problem with many web browsers and OSs with double-escaping (worked on Win), is it solved now when having uri instead of the escaped hardcoded URI prefix?

Idea for the future: Read the (BioPortal/OLS) abbreviation from the .owl file, and use that in the BioPortal & OLS links for any ontology. WebProtégé "dev" link too 😉

This comment has been minimized.

Sign in to view

Copy link
@bryan-brancotte

bryan-brancotte Aug 5, 2021

Member

Using only the identifier could be a good idea, but don't know how, do not hesitate to propose if you find how
", "+
"<a target=\"_blank\" href=\"https://www.ebi.ac.uk/ols/ontologies/edam/terms?iri=http%3A%2F%2Fedamontology.org%2F"+identifier+"\">OLS</a>"+
"<a target=\"_blank\" href=\"https://www.ebi.ac.uk/ols/ontologies/edam/terms?iri=http%3A%2F%2Fedamontology.org%2F"+identifier+"\">OLS</a> (latest stable)"+
" or "+
"<a target=\"_blank\" href=\"https://webprotege.stanford.edu/#projects/98640503-a37d-4404-84da-caf30fadd685/edit/Classes?selection=Class(%3Chttp://edamontology.org/"+identifier+"%3E)\">WebProt&eacuteg&eacute</a>"+
"<a target=\"_blank\" href=\"https://webprotege.stanford.edu/#projects/4befad5f-f27b-430c-a07d-fcf635093169/edit/Classes?selection=Class(%3Chttp://edamontology.org/"+identifier+"%3E)\">WebProt&eacuteg&eacute</a> (dev)"+

This comment has been minimized.

Sign in to view

Copy link
@matuskalas

matuskalas Aug 4, 2021

Author Member

Wouldn't it be more elegant & generic in both OLS and WebProtégé to use uri instead of the hardcoded URI prefix? (perhaps will have to be escaped)

This comment has been minimized.

Sign in to view

Copy link
@bryan-brancotte

bryan-brancotte Aug 5, 2021

Member

Agree
".","Links to this concept in other ontology browsers");
}
if (community.children().length>0){
Expand Down Expand Up @@ -922,4 +922,4 @@ window.cpyToClipboard = function cpyToClipboard(value){
}, 1000);
}

export {getInitURI,interactive_edam_browser,getTreeFile}
export {getInitURI,interactive_edam_browser,getTreeFile}

0 comments on commit d127208

Please sign in to comment.