-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making tree box extendable vertically! #157
Comments
Two things can be done here for better UI:
|
You are right @raashika03, but then a user might not get the idea of the existence of this feature. Let's see what our mentors suggest in this!
Yeah, I agree it would solve scrollability issue for smaller screens, but that would be possible with a button too. Or maybe we can create a frame sort of thing, which indicates that it is extendable. In the case of using a cursor, I might never notice this functionality ( until it's a mobile screen where we have an issue of scrollability) |
I agree with you @secrashi but then if we see like that then even feature like dragging of tree map is not shown anywhere explicitly.
A user will notice it with the change in cursor from pointer to resize one when they will scroll down to the empty spaces. Yes, let's wait for the mentors to suggest. what would be the best. |
Hi both of you, This issue is very interesting, and I would like to go even deeper and think of why we would add a vertical expand button. It is because we want to use all the space we have while keeping the right detail panel, and #141 worked in this direction. I would like to go further and introduce the second part : have in fullscreen the detail panel. There is an old feature that I disabled a long time ago as it was redundant with the detail panel on the right : the floating detail panel code: I think that If we could put more detail in this panel, we would solve the need adressed here, with a very intuitive approach. What are you views ? |
so do you mean,
empty space can be covered in other more useful ways. May be that bookmark option on which @secrashi is working. |
I would say yes @raashika03 Adding "Community usage" would be done later, and only on demande as it consume network and we could end up block with too much request on each service. |
Ok @bryan-brancotte I understood well. So may be you can create an issue for this :) then one can work. 😅 |
Hello @bryan-brancotte @matuskalas @hmenager, this issue is about making the tree box extendable vertically using a cursor. As discussed in comments of #91, I implemented this feature roughly and the video of same is attached below:
WhatsApp.Video.2021-04-29.at.1.43.01.PM.mp4
I thought of extending the box by stretching the bottom limit of the box, but then a new user won't know about this functionality, so I planned to add a button. Can you review and let me know if this would be a good add-on for our website? Also, since I already worked on this partially( not yet implemented to tree box), so it won't take much time and I'll soon make a PR!
The text was updated successfully, but these errors were encountered: