Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making tree box extandable vertically. #188

Merged
merged 12 commits into from
May 19, 2021

Conversation

sakshi-dhamija
Copy link
Contributor

Checklist

  • I indicated which issue (if any) is closed with this PR using closing keywords
  • I only changed lines related to my PR (no bulk reformatting)
  • I indicated the source and check the license if I re-use code, or I did not re-use code
  • I made my best to solve only one issue in this PR, or explain why multi had to be solved at once.

Issue

close #157

@raashika03
Copy link
Contributor

Providing some description will be nice for quick review at least.

@sakshi-dhamija
Copy link
Contributor Author

Hi @raashika03, Yeah agreed but I have explained this pretty well in the issue I linked, and the title of the PR did the remaining work about informing. So I didn't feel the point of writing a description.

@bryan-brancotte bryan-brancotte self-requested a review May 19, 2021 07:01
Copy link
Member

@bryan-brancotte bryan-brancotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @secrashi

Good job ! I did not knew that the solution could be as clear as this. 🏆

@bryan-brancotte bryan-brancotte merged commit 3b5bb2c into edamontology:main May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Making tree box extendable vertically!
3 participants