Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(webapp): set page title only if it exists #1404

Merged
merged 1 commit into from
Dec 12, 2023
Merged

fix(webapp): set page title only if it exists #1404

merged 1 commit into from
Dec 12, 2023

Conversation

Torresmorah
Copy link
Collaborator

Check if page title exists

What does this PR do?

Steps to test

  1. Run the project locally
  2. Go to an block producer profile
  3. Use the developer tools to simulate a slow connection
  4. Check the page title never is /block-producers/bpName>title

@Torresmorah Torresmorah self-assigned this Dec 11, 2023
xavier506
xavier506 approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@xavier506 xavier506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xavier506 xavier506 merged commit 3d85240 into dev Dec 12, 2023
4 checks passed
@xavier506 xavier506 deleted the fix/wrong-page-title-1403 branch December 12, 2023 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavier506 xavier506 xavier506 approved these changes

Assignees

@Torresmorah Torresmorah

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Indexing issue for BP Profiles
2 participants
@Torresmorah @xavier506