Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that paths are branded #1404

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

mmastrac
Copy link
Contributor

No description provided.

Copy link
Member

@msullivan msullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we will be able to just update these in place, if users already have edgedb installed. We can't lose all the previous local instances and edgedb installs.

I think we need to either:

  • Leave the directories named edgedb for now
  • Use edgedb if it exists, otherwise use gel
  • Have a migration path of some sort that involves moving the directories

The last option is a bit complicated since there may be active instances running that we'll need to stop first.

@mmastrac
Copy link
Contributor Author

Leave the directories named edgedb for now

Agree -- I will add an explicit comment here so that the directory names are extracted, but are not changed during rebranding. It'll make it easier to fix in the future.

src/branding.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants