Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set keep-alive on TCP sockets #330

Merged
merged 5 commits into from
Jun 27, 2024
Merged

Conversation

mmastrac
Copy link
Contributor

@mmastrac mmastrac commented Jun 25, 2024

Migrations and other long-running operations may leave a TCP connection active but without any traffic.

To prevent the operating systems on either end from closing the connections (or any other system that monitors for activity on TCP streams to determine when they should be closed), we can set the keep-alive flag on the client.

TODO:

  • Add config parameter

@mmastrac mmastrac changed the title wip: Set keep-alive on TCP sockets Set keep-alive on TCP sockets Jun 25, 2024
@mmastrac mmastrac requested a review from aljazerzen June 25, 2024 17:24
Copy link
Contributor

@aljazerzen aljazerzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mmastrac mmastrac merged commit 89662fd into edgedb:master Jun 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants