Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EDGEDB_USER and EDGEDB_PASSWORD from README.md #42

Closed
wants to merge 1 commit into from

Conversation

fmoor
Copy link
Member

@fmoor fmoor commented Nov 27, 2024

This is more of a question than a proposed change. I noticed that EDGEDB_USER is not in a single test, but is mentioned as a supported environment variable. Are we supposed to support it?

EDGEDB_PASSWORD is mentioned in the tests, but it is always either ignored in the result or it is the DSN option password_env target like in this test:

{
"env": {
"EDGEDB_PASSWORD": "password"
},
"name": "test_78",
"opts": {
"dsn": "edgedb://testuser@localhost/db?password_env=EDGEDB_PASSWORD"
},
"result": {
"branch": "db",
"database": "db",
"password": "password",
"user": "testuser"
}
},

There are no tests that assert that EDGEDB_PASSWORD is recognized by the client on its own. Are there any cases when EDGEDB_PASSWORD should be recognized by the client without the password_env DSN option?

My knee jerk assumption is that they should both be supported, but I'm not sure I remember all the rules and I'm not sure they are written down anywhere.

@msullivan
Copy link
Member

The Python bindings support EDGEDB_USER and EDGEDB_PASSWORD (and GEL_USER and GEL_PASSWORD).
My inclination is that they should be supported.

Copy link
Member

@msullivan msullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should test and support them

@fmoor
Copy link
Member Author

fmoor commented Jan 3, 2025

closing in favor of #43

@fmoor fmoor closed this Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants