Remove EDGEDB_USER and EDGEDB_PASSWORD from README.md #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more of a question than a proposed change. I noticed that
EDGEDB_USER
is not in a single test, but is mentioned as a supported environment variable. Are we supposed to support it?EDGEDB_PASSWORD
is mentioned in the tests, but it is always either ignored in the result or it is the DSN optionpassword_env
target like in this test:shared-client-testcases/tests/override/other.jsonc
Lines 1602 to 1616 in e395996
There are no tests that assert that
EDGEDB_PASSWORD
is recognized by the client on its own. Are there any cases whenEDGEDB_PASSWORD
should be recognized by the client without thepassword_env
DSN option?My knee jerk assumption is that they should both be supported, but I'm not sure I remember all the rules and I'm not sure they are written down anywhere.