-
Notifications
You must be signed in to change notification settings - Fork 54
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Move unit tests to new apply backend
Signed-off-by: Daniel Weiße <[email protected]>
- Loading branch information
1 parent
fd121c4
commit 1e834e4
Showing
8 changed files
with
335 additions
and
979 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,153 @@ | ||
| /* | ||
| Copyright (c) Edgeless Systems GmbH | ||
| SPDX-License-Identifier: AGPL-3.0-only | ||
| */ | ||
|
|
||
| package cmd | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
| "testing" | ||
|
|
||
| "github.com/edgelesssys/constellation/v2/cli/internal/helm" | ||
| "github.com/edgelesssys/constellation/v2/internal/file" | ||
| "github.com/edgelesssys/constellation/v2/internal/logger" | ||
| "github.com/spf13/afero" | ||
| "github.com/spf13/pflag" | ||
| "github.com/stretchr/testify/assert" | ||
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func TestParseApplyFlags(t *testing.T) { | ||
| require := require.New(t) | ||
| // TODO: Use flags := applyCmd().Flags() once we have a separate apply command | ||
| defaultFlags := func() *pflag.FlagSet { | ||
| flags := pflag.NewFlagSet("test", pflag.ContinueOnError) | ||
| flags.String("workspace", "", "") | ||
| flags.String("tf-log", "NONE", "") | ||
| flags.Bool("force", false, "") | ||
| flags.Bool("debug", false, "") | ||
| flags.Bool("merge-kubeconfig", false, "") | ||
| flags.Bool("conformance", false, "") | ||
| flags.Bool("skip-helm-wait", false, "") | ||
| flags.Bool("yes", false, "") | ||
| flags.StringSlice("skip-phases", []string{}, "") | ||
| flags.Duration("timeout", 0, "") | ||
| return flags | ||
| } | ||
|
|
||
| testCases := map[string]struct { | ||
| flags *pflag.FlagSet | ||
| wantFlags applyFlags | ||
| wantErr bool | ||
| }{ | ||
| "default flags": { | ||
| flags: defaultFlags(), | ||
| wantFlags: applyFlags{ | ||
| helmWaitMode: helm.WaitModeAtomic, | ||
| }, | ||
| }, | ||
| "skip phases": { | ||
| flags: func() *pflag.FlagSet { | ||
| flags := defaultFlags() | ||
| require.NoError(flags.Set("skip-phases", fmt.Sprintf("%s,%s", skipHelmPhase, skipK8sPhase))) | ||
| return flags | ||
| }(), | ||
| wantFlags: applyFlags{ | ||
| skipPhases: []skipPhase{skipHelmPhase, skipK8sPhase}, | ||
| helmWaitMode: helm.WaitModeAtomic, | ||
| }, | ||
| }, | ||
| "skip helm wait": { | ||
| flags: func() *pflag.FlagSet { | ||
| flags := defaultFlags() | ||
| require.NoError(flags.Set("skip-helm-wait", "true")) | ||
| return flags | ||
| }(), | ||
| wantFlags: applyFlags{ | ||
| helmWaitMode: helm.WaitModeNone, | ||
| }, | ||
| }, | ||
| } | ||
|
|
||
| for name, tc := range testCases { | ||
| t.Run(name, func(t *testing.T) { | ||
| assert := assert.New(t) | ||
| var flags applyFlags | ||
|
|
||
| err := flags.parse(tc.flags) | ||
| if tc.wantErr { | ||
| assert.Error(err) | ||
| return | ||
| } | ||
| assert.NoError(err) | ||
| assert.Equal(tc.wantFlags, flags) | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| func TestBackupHelmCharts(t *testing.T) { | ||
| testCases := map[string]struct { | ||
| helmApplier helm.Applier | ||
| backupClient *stubKubernetesUpgrader | ||
| includesUpgrades bool | ||
| wantErr bool | ||
| }{ | ||
| "success, no upgrades": { | ||
| helmApplier: &stubRunner{}, | ||
| backupClient: &stubKubernetesUpgrader{}, | ||
| }, | ||
| "success with upgrades": { | ||
| helmApplier: &stubRunner{}, | ||
| backupClient: &stubKubernetesUpgrader{}, | ||
| includesUpgrades: true, | ||
| }, | ||
| "saving charts fails": { | ||
| helmApplier: &stubRunner{ | ||
| saveChartsErr: assert.AnError, | ||
| }, | ||
| backupClient: &stubKubernetesUpgrader{}, | ||
| wantErr: true, | ||
| }, | ||
| "backup CRDs fails": { | ||
| helmApplier: &stubRunner{}, | ||
| backupClient: &stubKubernetesUpgrader{ | ||
| backupCRDsErr: assert.AnError, | ||
| }, | ||
| includesUpgrades: true, | ||
| wantErr: true, | ||
| }, | ||
| "backup CRs fails": { | ||
| helmApplier: &stubRunner{}, | ||
| backupClient: &stubKubernetesUpgrader{ | ||
| backupCRsErr: assert.AnError, | ||
| }, | ||
| includesUpgrades: true, | ||
| wantErr: true, | ||
| }, | ||
| } | ||
|
|
||
| for name, tc := range testCases { | ||
| t.Run(name, func(t *testing.T) { | ||
| assert := assert.New(t) | ||
|
|
||
| a := applyCmd{ | ||
| fileHandler: file.NewHandler(afero.NewMemMapFs()), | ||
| log: logger.NewTest(t), | ||
| } | ||
|
|
||
| err := a.backupHelmCharts(context.Background(), tc.backupClient, tc.helmApplier, tc.includesUpgrades, "") | ||
| if tc.wantErr { | ||
| assert.Error(err) | ||
| return | ||
| } | ||
| assert.NoError(err) | ||
| if tc.includesUpgrades { | ||
| assert.True(tc.backupClient.backupCRDsCalled) | ||
| assert.True(tc.backupClient.backupCRsCalled) | ||
| } | ||
| }) | ||
| } | ||
| } |
Oops, something went wrong.