-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: store kubernetes version as strong type in config #2287
Conversation
✅ Deploy Preview for constellation-docs canceled.
|
98a8f44
to
eb60156
Compare
8d4087f
to
3f824b4
Compare
Discuss: supporting versions without patch as K8s version might be worth putting in the release notes |
@derpsteb I reverted the support for no patch specification in the config due to complicated case handling. I think it's not worth to support it, but have saved the stash if we decide to do so in the future |
04a0f56
to
9c54bc0
Compare
Coverage report
|
What's interesting about these metrics is that it doesn't encourage to test closer to E2E. I.e, the added test cases for the valid Kubernetes flag values in config generate do not add to the test coverage because it exercises code from the |
9a9916e
to
9462b70
Compare
9462b70
to
7d3ce1f
Compare
Co-authored-by: Otto Bittner <[email protected]>
Co-authored-by: Otto Bittner <[email protected]>
Co-authored-by: 3u13r <[email protected]>
7d3ce1f
to
038d9f8
Compare
038d9f8
to
36a7e74
Compare
@3u13r can u give it another look pls when u find a moment? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nit, otherwise LGTM
36a7e74
to
bff1570
Compare
Context
Storing the K8s version as validated type saves a lot of parameter passing and centralizes the validation logic
Proposed change(s)
allow to specify K8s version without patch (e.g. 1.27) as valid config value and resolve the patch versionconfig generate
(e.g. 1.27.4)Related issue
Checklist