Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: new flag to skip phases of upgrade #2310

Merged
merged 8 commits into from
Sep 8, 2023
Merged

cli: new flag to skip phases of upgrade #2310

merged 8 commits into from
Sep 8, 2023

Conversation

elchead
Copy link
Contributor

@elchead elchead commented Sep 6, 2023 •
edited
Loading

Context

Currently it is not possible to select / deselect specific upgrades (terraform, helm, k8s, node image).

Proposed change(s)

  • add a new --skip-phases flag that accepts a list of phases to skip during the upgrade

Related issue

Checklist

  • Update docs
  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@elchead elchead added the feature This introduces new functionality label Sep 6, 2023
@elchead elchead added this to the v2.11.0 milestone Sep 6, 2023
@netlify
Copy link

netlify bot commented Sep 6, 2023 •
edited
Loading

✅ Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 98f99f5
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/64fb0063aae3a300081cca1e

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023 •
edited
Loading

Coverage report

Package Old New Trend
cli/internal/cmd 54.20% 55.30% ↗️
cli/internal/kubecmd 57.70% 58.00% ↗️

@elchead elchead mentioned this pull request Sep 6, 2023
Merged
4 tasks
daniel-weisse
daniel-weisse reviewed Sep 6, 2023
View reviewed changes
cli/internal/cmd/upgradeapply.go Outdated Show resolved Hide resolved
cli/internal/cmd/upgradeapply.go Outdated Show resolved Hide resolved
cli/internal/cmd/upgradeapply.go Outdated Show resolved Hide resolved
@elchead elchead force-pushed the feat/cli/skip-phases-upgrade branch from 1845021 to c8721ba Compare September 6, 2023 12:35
daniel-weisse
daniel-weisse approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@daniel-weisse daniel-weisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a ticket to document this feature?

cli/internal/cmd/upgradeapply.go Outdated Show resolved Hide resolved
@elchead elchead force-pushed the feat/cli/skip-phases-upgrade branch from 3de166e to 80fe05a Compare September 6, 2023 13:12
@derpsteb derpsteb removed their request for review September 7, 2023 09:31
thomasten
thomasten requested changes Sep 8, 2023
View reviewed changes
cli/internal/cmd/upgradeapply.go Show resolved Hide resolved
cli/internal/cmd/upgradeapply.go Outdated Show resolved Hide resolved
cli/internal/cmd/upgradeapply.go Outdated Show resolved Hide resolved
@elchead elchead force-pushed the feat/cli/skip-phases-upgrade branch from 5923bbf to c180014 Compare September 8, 2023 10:44
@elchead elchead force-pushed the feat/cli/skip-phases-upgrade branch from c180014 to 98f99f5 Compare September 8, 2023 11:07
thomasten
thomasten approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@thomasten thomasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. (I haven't tried it out.)

@elchead elchead merged commit 5960025 into main Sep 8, 2023
1 check failed
@elchead elchead deleted the feat/cli/skip-phases-upgrade branch September 8, 2023 12:55
@3u13r 3u13r mentioned this pull request Sep 8, 2023
Merged
4 tasks
@elchead elchead mentioned this pull request Sep 12, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-weisse daniel-weisse daniel-weisse approved these changes

@thomasten thomasten thomasten approved these changes

@malt3 malt3 malt3 approved these changes

Assignees
No one assigned
Labels
feature This introduces new functionality
Projects
None yet
Milestone
v2.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@elchead @malt3 @thomasten @daniel-weisse