cli: check chart versions against target version in users config before upgrading #2319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for constellation-docs canceled.
|
Coverage report
|
daniel-weisse
force-pushed
the
fix/cli/config-microservice-version-checking
branch
from
db2a183 to
3146c37
Compare
|
LGTM. We definitely need those checks. I will let Adrian give the final approval as he is working on that code much more actively. |
derpsteb
reviewed
Sep 8, 2023
| "helm.sh/helm/v3/pkg/chart" | ||
| ) | ||
|
|
||
| func TestAppendNewAction(t *testing.T) { |
elchead
reviewed
Sep 8, 2023
elchead
reviewed
Sep 8, 2023
daniel-weisse
force-pushed
the
fix/cli/config-microservice-version-checking
branch
2 times, most recently
from
aaa97d9 to
36fcbdf
Compare
elchead
approved these changes
Sep 8, 2023
There was a problem hiding this comment.
should we run a no-op + upgrade test E2E before merging?
upgrade:
https://github.com/edgelesssys/constellation/actions/runs/6120817357
no-op:
https://github.com/edgelesssys/constellation/actions/runs/6120821079
Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
daniel-weisse
force-pushed
the
fix/cli/config-microservice-version-checking
branch
from
36fcbdf to
60f53f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Our CLI embeds the Helm charts used for the Kubernetes cluster.
For charts we pull in from external providers, the version of these charts is dependent on the version we set for that release.
For charts we package ourselves, the version of the chart is dependent on the version of the CLI binary.
For these charts, on
constellation upgrade apply, we should only apply an upgrade if the version specifies in the user's config is an upgrade to the version running in their cluster. And only to the version set in the config.For this the Helm code is currently missing some checks.
Proposed change(s)
appendNewActionmethodAdditional info