Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: retry helm apply on any error #2322

Merged
merged 1 commit into from
Sep 8, 2023
Merged

cli: retry helm apply on any error #2322

merged 1 commit into from
Sep 8, 2023

Conversation

daniel-weisse
Copy link
Member

Context

We have retry logic for installing/upgrading helm charts.
However, we have a rather restrictive check for what errors are retried in case installing/upgrading fails.

Proposed change(s)

  • Instead of checking for specific errors to retry, retry on any error
    • If we ever encounter some error cases we definitely don't want to retry, we should just add exceptions for these errors, instead of keeping a list of errors we want to retry.

Related issue

Checklist

  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@daniel-weisse daniel-weisse added the bug fix Fixing a bug label Sep 8, 2023
@daniel-weisse daniel-weisse added this to the v2.11.0 milestone Sep 8, 2023
@netlify
Copy link

netlify bot commented Sep 8, 2023

Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 93aab8a
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/64fb12ef5e39e60008f3d9c0

Copy link
Contributor

@elchead elchead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Daniel Weiße <[email protected]>
@daniel-weisse daniel-weisse force-pushed the fix/cli/helm-retry-logic branch from 2267e9b to 93aab8a Compare September 8, 2023 12:26
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Coverage report

Package Old New Trend
cli/internal/helm 43.80% 47.80% ↗️

@3u13r 3u13r merged commit 5706e69 into main Sep 8, 2023
@3u13r 3u13r deleted the fix/cli/helm-retry-logic branch September 8, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants