Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: remove TF ApplyOutput dependency in CLI #2323

Merged
merged 2 commits into from
Sep 25, 2023
Merged

cli: remove TF ApplyOutput dependency in CLI #2323

merged 2 commits into from
Sep 25, 2023

Conversation

elchead
Copy link
Contributor

@elchead elchead commented Sep 8, 2023 •
edited
Loading

Context

This is part of the effort to support self-managed infrastructure and decouple from Terraform state.

Proposed change(s)

Related issue

Checklist

  • Update docs
  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@elchead elchead added the no changelog Change won't be listed in release changelog label Sep 8, 2023
@elchead elchead changed the title cli: remove TF applyOutput dependency cli: remove TF ApplyOutput dependency in CLI Sep 8, 2023
@elchead elchead marked this pull request as ready for review September 8, 2023 12:46
@3u13r 3u13r added this to the v2.12.0 milestone Sep 8, 2023
@elchead elchead force-pushed the feat/cli/infrastructure-state branch from 61747c3 to 2355be8 Compare September 11, 2023 08:15
@elchead elchead force-pushed the feat/cli/remove-tf-output-dep branch from ed6c1b0 to e098f35 Compare September 11, 2023 08:30
@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2023 •
edited
Loading

Coverage report

Package Old New Trend
cli/internal/cloudcmd 63.90% 63.90% ↔️
cli/internal/cmd 56.10% 56.10% ↔️
cli/internal/terraform 68.50% 71.40% ↗️

@elchead elchead force-pushed the feat/cli/infrastructure-state branch from 2355be8 to d4aa307 Compare September 11, 2023 11:22
@daniel-weisse
Copy link
Member

This has quite a lot of conflicts currently. Can you rebase before I start reviewing?

@elchead
Copy link
Contributor Author

elchead commented Sep 21, 2023

This has quite a lot of conflicts currently. Can you rebase before I start reviewing?

sure but this should follow after the state file PR so lets start with this :)

@elchead elchead force-pushed the feat/cli/infrastructure-state branch from cd3a85b to d206a59 Compare September 21, 2023 13:39
@elchead elchead force-pushed the feat/cli/remove-tf-output-dep branch from e098f35 to 3554968 Compare September 21, 2023 13:49
daniel-weisse
daniel-weisse approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@daniel-weisse daniel-weisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you

@elchead elchead force-pushed the feat/cli/infrastructure-state branch from 5ce0d30 to e603c2e Compare September 25, 2023 12:25
Base automatically changed from feat/cli/infrastructure-state to main September 25, 2023 14:19
@elchead elchead force-pushed the feat/cli/remove-tf-output-dep branch from b18310c to a070ac9 Compare September 25, 2023 14:45
@netlify
Copy link

netlify bot commented Sep 25, 2023

✅ Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit a070ac9
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/65119cf07da35600086c77ec

@elchead elchead merged commit 4680882 into main Sep 25, 2023
@elchead elchead deleted the feat/cli/remove-tf-output-dep branch September 25, 2023 15:10
msanft pushed a commit that referenced this pull request Sep 27, 2023
@elchead @msanft
cli: remove TF ApplyOutput dependency in CLI (#2323)
929ff0c
derpsteb pushed a commit that referenced this pull request Oct 2, 2023
@elchead @derpsteb
cli: remove TF ApplyOutput dependency in CLI (#2323)
2295459
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-weisse daniel-weisse daniel-weisse approved these changes

@derpsteb derpsteb derpsteb approved these changes

Assignees
No one assigned
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Milestone
v2.12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@elchead @daniel-weisse @derpsteb @3u13r