Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debugd: send requests over lb #2346

Merged
merged 1 commit into from
Sep 19, 2023
Merged

debugd: send requests over lb #2346

merged 1 commit into from
Sep 19, 2023

Conversation

3u13r
Copy link
Member

@3u13r 3u13r commented Sep 19, 2023

Context

Proposed change(s)

  • Remove unnecessary CanSend() function, as receiveFinished is already checked during transfer.SendFiles()
  • Adds loadbalancer IP to the ips to try to get the bootstrapper from

The second change is necessary as in the future, all nodes in the cluster are not allowed to send out unencrypted traffic to the node CIDR.

Checklist

  • Add labels (e.g., for changelog category)
  • Link to Milestone

@3u13r 3u13r requested a review from malt3 as a code owner September 19, 2023 13:16
@netlify
Copy link

netlify bot commented Sep 19, 2023

✅ Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit e88fd86
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/65099f44e4fd6900084269c7

@github-actions
Copy link
Contributor

Coverage report

Package Old New Trend
debugd/internal/debugd/metadata 92.90% 94.10% ↗️
debugd/internal/debugd/metadata/cloudprovider 75.90% 75.90% ↔️
debugd/internal/debugd/server 71.70% 70.70% ↘️
debugd/internal/filetransfer 100.00% 100.00% ↔️

@3u13r 3u13r force-pushed the feat/debugd/request-over-lb branch from 5621dfe to e88fd86 Compare September 19, 2023 13:20
@3u13r 3u13r mentioned this pull request Sep 19, 2023
Closed
2 tasks
malt3
malt3 approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@malt3 malt3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@3u13r 3u13r merged commit 548bb2d into main Sep 19, 2023
@3u13r 3u13r deleted the feat/debugd/request-over-lb branch September 19, 2023 14:10
@malt3 malt3 added the no changelog Change won't be listed in release changelog label Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malt3 malt3 malt3 approved these changes

Assignees
No one assigned
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@3u13r @malt3