cli: report log collection failure to user #2354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Weiße <[email protected]>
✅ Deploy Preview for constellation-docs canceled.
|
Coverage report
|
thomasten
requested changes
Sep 24, 2023
Signed-off-by: Daniel Weiße <[email protected]>
thomasten
approved these changes
Sep 25, 2023
Signed-off-by: Daniel Weiße <[email protected]>
msanft
pushed a commit
that referenced
this pull request
Sep 27, 2023
* Report log collection failure to user * Try collecting logs for more error cases --------- Signed-off-by: Daniel Weiße <[email protected]>
derpsteb
pushed a commit
that referenced
this pull request
Oct 2, 2023
* Report log collection failure to user * Try collecting logs for more error cases --------- Signed-off-by: Daniel Weiße <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
During
constellation init, if the init request and the subsequent log collection fails, the CLI reports "Fetched bootstrapper logs are stored in ...".This is not true, since the log collection itself failed.
Proposed change(s)
Properly report log collection failed, if it did.
Related issue
AB#3272