Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: write MAAUrl to idfile again #2387

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

3u13r
Copy link
Member

@3u13r 3u13r commented Sep 27, 2023

Context

Proposed change(s)

e2e verify on azure: https://github.com/edgelesssys/constellation/actions/runs/6326048674

Checklist

  • Add labels (e.g., for changelog category)
  • Link to Milestone

@3u13r 3u13r added bug fix Fixing a bug no changelog Change won't be listed in release changelog labels Sep 27, 2023
@netlify
Copy link

netlify bot commented Sep 27, 2023

Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 2039845
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/6514229b29a8f90008086e78

@3u13r 3u13r requested a review from elchead September 27, 2023 12:40
@github-actions
Copy link
Contributor

Coverage report

Package Old New Trend
cli/internal/cmd 56.10% 56.10% ↔️

@msanft
Copy link
Contributor

msanft commented Sep 27, 2023

As a long-term solution, we should read from the state file in constellation verify instead. I'm currently working on the required handlers for the state file. (e.g. read from local state file) We can take this as a temporary fix but should add a TODO here regarding that. (Can be assigned to me)

@3u13r
Copy link
Member Author

3u13r commented Sep 27, 2023

As a long-term solution, we should read from the state file in constellation verify instead.

Yes, but the authors original intention seems to be to already create the state file but still keed the id file (correctly) around, hence this way of fixing this.

@3u13r 3u13r merged commit ac2fca3 into main Sep 27, 2023
10 checks passed
@3u13r 3u13r deleted the fix/create/write-maaurl-to-idfile-again branch September 27, 2023 15:40
derpsteb pushed a commit that referenced this pull request Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Fixing a bug no changelog Change won't be listed in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants