ci: ensure API is only updated if image and measurements are uploaded #2413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aded Signed-off-by: Daniel Weiße <[email protected]>
✅ Deploy Preview for constellation-docs canceled.
|
derpsteb
approved these changes
Oct 6, 2023
malt3
approved these changes
Oct 6, 2023
|
🏌️ |
msanft
pushed a commit
that referenced
this pull request
Oct 9, 2023
…#2413) Signed-off-by: Daniel Weiße <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
As part of our image build pipeline, our API is updated to include measurements and a reference to the image in the API.
Currently, the image build may fail when calculating the expected measurements, but the API is still updated.
This means our API reports a image as being available, even though the build pipeline failed.
While this does not impact regular users, it impacts our E2E tests which automatically use the latest available image version and try to fetch measurements for that version.
If the measurements are not available, the test fails.
Proposed change(s)
Additional info
Checklist