Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

attestation: update list of accepted id key digests #2415

Merged
merged 1 commit into from
Oct 6, 2023
Merged

attestation: update list of accepted id key digests #2415

merged 1 commit into from
Oct 6, 2023

Conversation

msanft
Copy link
Contributor

@msanft msanft commented Oct 6, 2023 •
edited by azure-boards bot
Loading

Context

The default list of accepted ID key digests didn't reflect what actually seems to currently be in use at Azure.

Proposed change(s)

  • Remove all ID key digests except the one that was seen throughout CI (e2e weekly) runs within the last 2 months.

Additional info

Checklist

  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@msanft msanft added the no changelog Change won't be listed in release changelog label Oct 6, 2023
@msanft msanft added this to the v2.12.0 milestone Oct 6, 2023
@msanft msanft requested a review from thomasten October 6, 2023 08:42
@msanft msanft requested a review from daniel-weisse as a code owner October 6, 2023 08:42
@netlify
Copy link

netlify bot commented Oct 6, 2023

✅ Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 3277bd2
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/651fc8780766aa0008f02592

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Coverage report

Package Old New Trend
internal/attestation/idkeydigest 75.00% 75.00% ↔️

thomasten
thomasten approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@thomasten thomasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@msanft msanft merged commit d0fe6c9 into main Oct 6, 2023
7 checks passed
@msanft msanft deleted the feat/attestation/remove-old-idkeydigests branch October 6, 2023 09:32
msanft added a commit that referenced this pull request Oct 9, 2023
@msanft
update list of default idkeydigests (#2415)
7dd0607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-weisse daniel-weisse daniel-weisse approved these changes

@thomasten thomasten thomasten approved these changes

Assignees
No one assigned
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Milestone
v2.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@msanft @thomasten @daniel-weisse