Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renovate: relax rules to allow updates to minor versions #2423

Merged
merged 1 commit into from
Oct 11, 2023
Merged

renovate: relax rules to allow updates to minor versions #2423

merged 1 commit into from
Oct 11, 2023

Conversation

miampf
Copy link
Contributor

@miampf miampf commented Oct 10, 2023 •
edited
Loading

Context

Renovate fails to update minor versions of certain packages like filebeat-debugd.

Proposed change(s)

  • add "ignoreUnstable": false to the package Rule that matches "ghcr.io/edgelesssys" to allow updates to later prereleases.
  • add comments to the renovate.json5 file that make it easier to navigate.

Additional info

Checklist

  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@miampf miampf added bug fix Fixing a bug no changelog Change won't be listed in release changelog labels Oct 10, 2023
@miampf miampf added this to the v2.12.0 milestone Oct 10, 2023
@miampf miampf requested review from malt3 and katexochen October 10, 2023 13:03
@katexochen katexochen changed the title fix: relax renovate rules to allow updates to minor versions renovate: relax rules to allow updates to minor versions Oct 10, 2023
@edgelesssys edgelesssys deleted a comment from netlify bot Oct 10, 2023
@miampf
Copy link
Contributor Author

miampf commented Oct 10, 2023 •
edited
Loading

You can read about ignoreUnstable here

@miampf miampf force-pushed the renovate-minor-versions-fix branch from f991cc4 to 5f16aee Compare October 10, 2023 13:33
katexochen
katexochen approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@katexochen katexochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@malt3 malt3 modified the milestones: v2.12.0, v2.13.0 Oct 10, 2023
@miampf miampf merged commit e6e1ac5 into main Oct 11, 2023
4 checks passed
@miampf miampf deleted the renovate-minor-versions-fix branch October 11, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katexochen katexochen katexochen approved these changes

@malt3 malt3 malt3 approved these changes

Assignees
No one assigned
Labels
bug fix Fixing a bug no changelog Change won't be listed in release changelog
Projects
None yet
Milestone
v2.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@miampf @malt3 @katexochen